diff options
author | blackst0ne <blackst0ne.ru@gmail.com> | 2018-12-21 23:32:25 +1100 |
---|---|---|
committer | blackst0ne <blackst0ne.ru@gmail.com> | 2018-12-21 23:32:25 +1100 |
commit | f40478fe194113722d5db5e066acde37a7cdbd85 (patch) | |
tree | 6925a48c89cbcc4cc153a8e272dcf0e4c4344a6f /app/services | |
parent | 6964e510534c1d08fd730918ba3b9581dbd679a6 (diff) | |
download | gitlab-ce-f40478fe194113722d5db5e066acde37a7cdbd85.tar.gz |
Bump Ruby on Rails to 5.0.7.1blackst0ne-bump-rails-cve-2018-16476
Fix the CVE-2018-16476 vulnerability.
Diffstat (limited to 'app/services')
-rw-r--r-- | app/services/merge_requests/update_service.rb | 6 | ||||
-rw-r--r-- | app/services/notification_service.rb | 2 |
2 files changed, 5 insertions, 3 deletions
diff --git a/app/services/merge_requests/update_service.rb b/app/services/merge_requests/update_service.rb index aacaf10d09c..1b447605a00 100644 --- a/app/services/merge_requests/update_service.rb +++ b/app/services/merge_requests/update_service.rb @@ -45,11 +45,13 @@ module MergeRequests end if merge_request.previous_changes.include?('assignee_id') + reassigned_merge_request_args = [merge_request, current_user] + old_assignee_id = merge_request.previous_changes['assignee_id'].first - old_assignee = User.find(old_assignee_id) if old_assignee_id + reassigned_merge_request_args << User.find(old_assignee_id) if old_assignee_id create_assignee_note(merge_request) - notification_service.async.reassigned_merge_request(merge_request, current_user, old_assignee) + notification_service.async.reassigned_merge_request(*reassigned_merge_request_args) todo_service.reassigned_merge_request(merge_request, current_user) end diff --git a/app/services/notification_service.rb b/app/services/notification_service.rb index ff035fea216..e1cf327209b 100644 --- a/app/services/notification_service.rb +++ b/app/services/notification_service.rb @@ -188,7 +188,7 @@ class NotificationService # * merge_request assignee if their notification level is not Disabled # * users with custom level checked with "reassign merge request" # - def reassigned_merge_request(merge_request, current_user, previous_assignee) + def reassigned_merge_request(merge_request, current_user, previous_assignee = nil) recipients = NotificationRecipientService.build_recipients( merge_request, current_user, |