Add specs for models and services

1 files changed, 16 insertions, 24 deletions

diff --git a/app/services/create_deployment_service.rb b/app/services/create_deployment_service.rb
index 7408ec367f6..eec1773073e 100644
--- a/app/services/create_deployment_service.rb
+++ b/app/services/create_deployment_service.rb
@@ -1,38 +1,30 @@
 require_relative 'base_service'
 
 class CreateDeploymentService < BaseService
-  def execute(deployable)
-    environment = find_environment(params[:environment])
-    return error('no environment') unless environmnet
+  def execute(deployable = nil)
+    environment = create_or_find_environment(params[:environment])
 
-    deployment = create_deployment(environment, deployable)
-    if deployment.persisted?
-      success(deployment)
-    else
-      error(deployment.errors)
-    end
+    project.deployments.create(
+      environment: environment,
+      ref: params[:ref],
+      tag: params[:tag],
+      sha: params[:sha],
+      user: current_user,
+      deployable: deployable,
+    )
   end
 
   private
 
-  def find_environment(environment)
-    project.environments.find_by(name: environment)
+  def create_or_find_environment(environment)
+    find_environment(environment) || create_environment(environment)
   end
 
-  def create_deployment(environment, deployable)
-    environment.deployments.create(
-      project: project,
-      ref: build.ref,
-      tag: build.tag,
-      sha: build.sha,
-      user: current_user,
-      deployable: deployable,
-    )
+  def create_environment(environment)
+    project.environments.create(name: environment)
   end
 
-  def success(deployment)
-    out = super()
-    out[:deployment] = deployment
-    out
+  def find_environment(environment)
+    project.environments.find_by(name: environment)
   end
 end