summaryrefslogtreecommitdiff
path: root/app/services
diff options
context:
space:
mode:
authorYorick Peterse <yorickpeterse@gmail.com>2016-03-24 17:00:26 +0100
committerYorick Peterse <yorickpeterse@gmail.com>2016-04-01 11:13:48 +0200
commit84b0ab77667b85a42db8a5a02d9758657af66f16 (patch)
tree5058f048563c8d8e8be4b7e0837d919ff0a878d4 /app/services
parent82539cff700931532b22b6a8e3d6832137fc5d55 (diff)
downloadgitlab-ce-84b0ab77667b85a42db8a5a02d9758657af66f16.tar.gz
Added & use Gitlab::Routing for URL helpersrouting
Rails' "url_helpers" method creates an anonymous Module (which a bunch of methods) on every call. By caching the output of this method in a dedicated method we can shave off about 10 seconds of loading time for an issue with around 200 comments.
Diffstat (limited to 'app/services')
-rw-r--r--app/services/system_note_service.rb2
1 files changed, 1 insertions, 1 deletions
diff --git a/app/services/system_note_service.rb b/app/services/system_note_service.rb
index e022a046c48..658b086496f 100644
--- a/app/services/system_note_service.rb
+++ b/app/services/system_note_service.rb
@@ -224,7 +224,7 @@ class SystemNoteService
#
# "Started branch `issue-branch-button-201`"
def self.new_issue_branch(issue, project, author, branch)
- h = Gitlab::Application.routes.url_helpers
+ h = Gitlab::Routing.url_helpers
link = h.namespace_project_compare_url(project.namespace, project, from: project.default_branch, to: branch)
body = "Started branch [`#{branch}`](#{link})"