summaryrefslogtreecommitdiff
path: root/app/services
diff options
context:
space:
mode:
authorJames Lopez <james@jameslopez.es>2016-02-17 10:42:59 +0100
committerJames Lopez <james@jameslopez.es>2016-02-17 10:42:59 +0100
commit5255a54df9778b107734a84acb85230d62d3cff7 (patch)
tree6979d5094735e08f63fb5bac3cbd84848ae8d8d3 /app/services
parent20e79f714a4b98526d5eeffc82c0de89c8369c4e (diff)
downloadgitlab-ce-5255a54df9778b107734a84acb85230d62d3cff7.tar.gz
refactored some stuff based on MR feedback
Diffstat (limited to 'app/services')
-rw-r--r--app/services/git_push_service.rb6
1 files changed, 3 insertions, 3 deletions
diff --git a/app/services/git_push_service.rb b/app/services/git_push_service.rb
index b203065e708..a1711d234ff 100644
--- a/app/services/git_push_service.rb
+++ b/app/services/git_push_service.rb
@@ -106,7 +106,7 @@ class GitPushService < BaseService
def build_push_data
@push_data ||= Gitlab::PushDataBuilder.
- build(@project, current_user, params[:oldrev], params[:newrev], params[:ref], push_commits)
+ build(@project, current_user, params[:oldrev], params[:newrev], params[:ref], push_commits)
end
def push_to_existing_branch?
@@ -128,7 +128,7 @@ class GitPushService < BaseService
def is_default_branch?
Gitlab::Git.branch_ref?(params[:ref]) &&
- (Gitlab::Git.ref_name(params[:ref]) == project.default_branch || project.default_branch.nil?)
+ (Gitlab::Git.ref_name(params[:ref]) == project.default_branch || project.default_branch.nil?)
end
def commit_user(commit)
@@ -136,6 +136,6 @@ class GitPushService < BaseService
end
def branch_name
- @_branch_name ||= Gitlab::Git.ref_name(params[:ref])
+ @branch_name ||= Gitlab::Git.ref_name(params[:ref])
end
end