summaryrefslogtreecommitdiff
path: root/app/uploaders/personal_file_uploader.rb
diff options
context:
space:
mode:
authorSean McGivern <sean@gitlab.com>2019-05-11 07:06:44 -0500
committerSean McGivern <sean@gitlab.com>2019-05-14 11:01:48 -0500
commit79dd92c8189600f24a29fe2da8d391cdb021f8fd (patch)
treefff4f45718495005bcacc82156bf7fc05943a568 /app/uploaders/personal_file_uploader.rb
parent513fa60310e5b5d8dbdf81daf0c6ae7e506b4d8b (diff)
downloadgitlab-ce-79dd92c8189600f24a29fe2da8d391cdb021f8fd.tar.gz
Optimise upload path calls
String#underscore isn't particularly slow, but it's possible for us to call it many times in a users autocomplete request, with mostly-static values ('User', 'Group', etc.). We can memoise this and save a surprising amount of time (around 10% of the total request time in some cases).
Diffstat (limited to 'app/uploaders/personal_file_uploader.rb')
-rw-r--r--app/uploaders/personal_file_uploader.rb2
1 files changed, 1 insertions, 1 deletions
diff --git a/app/uploaders/personal_file_uploader.rb b/app/uploaders/personal_file_uploader.rb
index 272837aa6ce..f4697d898af 100644
--- a/app/uploaders/personal_file_uploader.rb
+++ b/app/uploaders/personal_file_uploader.rb
@@ -20,7 +20,7 @@ class PersonalFileUploader < FileUploader
def self.model_path_segment(model)
return 'temp/' unless model
- File.join(model.class.to_s.underscore, model.id.to_s)
+ File.join(model.class.underscore, model.id.to_s)
end
def object_store