summaryrefslogtreecommitdiff
path: root/app/uploaders
diff options
context:
space:
mode:
authorJohann Pardanaud <pardanaud.j@gmail.com>2016-02-18 13:09:51 +0100
committerJohann Pardanaud <pardanaud.j@gmail.com>2016-02-18 13:12:39 +0100
commit0701b70c9c47e90a96100cefe5b93ec5954f9ec1 (patch)
tree9a4994634f74c23c8143d08acd920323b832852a /app/uploaders
parentbf6aa15512cc6d31be320204fbc3c115bfd11b1b (diff)
downloadgitlab-ce-0701b70c9c47e90a96100cefe5b93ec5954f9ec1.tar.gz
Minor changes on avatar cropping internals
- Avoid multiple calls to `validates` for the avatar attributes. - In a cropping process, don't check if the model inherits `User`, check if it responds to `:avatar_crop_size`.
Diffstat (limited to 'app/uploaders')
-rw-r--r--app/uploaders/avatar_uploader.rb8
1 files changed, 4 insertions, 4 deletions
diff --git a/app/uploaders/avatar_uploader.rb b/app/uploaders/avatar_uploader.rb
index c8d9ab072e8..2c72df44ff0 100644
--- a/app/uploaders/avatar_uploader.rb
+++ b/app/uploaders/avatar_uploader.rb
@@ -11,10 +11,10 @@ class AvatarUploader < CarrierWave::Uploader::Base
process :cropper
def cropper
- if model.kind_of?(User) && model.valid?
- manipulate! do |img|
- img.crop "#{model.avatar_crop_size}x#{model.avatar_crop_size}+#{model.avatar_crop_x}+#{model.avatar_crop_y}"
- end
+ return unless model.respond_to?(:avatar_crop_size) && model.valid?
+
+ manipulate! do |img|
+ img.crop "#{model.avatar_crop_size}x#{model.avatar_crop_size}+#{model.avatar_crop_x}+#{model.avatar_crop_y}"
end
end