summaryrefslogtreecommitdiff
path: root/app/validators
diff options
context:
space:
mode:
authorJames Lopez <james@jameslopez.es>2016-06-17 15:09:39 +0200
committerJames Lopez <james@jameslopez.es>2016-06-17 15:09:39 +0200
commit0e222f02d8b8de24577b754eea4539b29621719f (patch)
tree952ed6e9c5663344453e060f579321b04eed9130 /app/validators
parent077e32740c150cb4216f5ecf74229df159dceea0 (diff)
downloadgitlab-ce-0e222f02d8b8de24577b754eea4539b29621719f.tar.gz
fixing URL validation for import_url on projects
Diffstat (limited to 'app/validators')
-rw-r--r--app/validators/addressable_url_validator.rb49
1 files changed, 49 insertions, 0 deletions
diff --git a/app/validators/addressable_url_validator.rb b/app/validators/addressable_url_validator.rb
new file mode 100644
index 00000000000..4e1a01a1bff
--- /dev/null
+++ b/app/validators/addressable_url_validator.rb
@@ -0,0 +1,49 @@
+# UrlValidator
+#
+# Custom validator for URLs.
+#
+# By default, only URLs for the HTTP(S) protocols will be considered valid.
+# Provide a `:protocols` option to configure accepted protocols.
+#
+# Example:
+#
+# class User < ActiveRecord::Base
+# validates :personal_url, url: true
+#
+# validates :ftp_url, url: { protocols: %w(ftp) }
+#
+# validates :git_url, url: { protocols: %w(http https ssh git) }
+# end
+#
+class AddressableUrlValidator < ActiveModel::EachValidator
+ def validate_each(record, attribute, value)
+ unless valid_url?(value)
+ record.errors.add(attribute, "must be a valid URL")
+ end
+ end
+
+ private
+
+ def default_options
+ @default_options ||= { protocols: %w(http https ssh git) }
+ end
+
+ def valid_url?(value)
+ return false unless value
+
+ value.strip!
+
+ valid_uri?(value) && valid_protocol?(value)
+ rescue Addressable::URI::InvalidURIError
+ false
+ end
+
+ def valid_uri?(value)
+ Addressable::URI.parse(strip).is_a?(Addressable::URI)
+ end
+
+ def valid_protocol?(value)
+ options = default_options.merge(self.options)
+ value =~ /\A#{URI.regexp(options[:protocols])}\z/
+ end
+end