diff options
| author | Fatih Acet <acetfatih@gmail.com> | 2016-10-14 21:11:05 +0000 |
|---|---|---|
| committer | Fatih Acet <acetfatih@gmail.com> | 2016-10-14 21:11:05 +0000 |
| commit | ecd7e99a0abbceafa3559a6cd9642f8ce6cea020 (patch) | |
| tree | 1f7b2176a66fcff576fa9f57691d38983b61e263 /app/views/admin | |
| parent | 05762f449e7620015923eedcbacde8cec1eabf52 (diff) | |
| parent | 64609ba84845969ef084aee3058ce2fbea582a3f (diff) | |
| download | gitlab-ce-ecd7e99a0abbceafa3559a6cd9642f8ce6cea020.tar.gz | |
Merge branch '23167-min-row-height' into 'master'
Resolve "Build/Pipeline/Environment List Inconsistency Row Height"
#### What does this MR do?
* Changes generic table class from `builds` to `ci-table`. It was getting confusing using `builds` for `builds`, `pipelines`, `environments`
* Sets height on builds rows for continuity
#### Are there points in the code the reviewer needs to double check?
Apparently you can't set `min-height` on any `table` elements but you _can_ set `height`. For some reason, even if the content within happens to start wrapping, the row height will grow instead of letting the content overlap. Which is a good thing. Just kind of weird.
#### Why was this MR needed?
Different row heights on builds depending on content
#### Screenshots (if relevant)
Before:
After:
Before:
After:
## What are the relevant issue numbers?
Closes #23167
See merge request !6787
Diffstat (limited to 'app/views/admin')
| -rw-r--r-- | app/views/admin/runners/show.html.haml | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/app/views/admin/runners/show.html.haml b/app/views/admin/runners/show.html.haml index a5e82e55cc1..10fea1996aa 100644 --- a/app/views/admin/runners/show.html.haml +++ b/app/views/admin/runners/show.html.haml @@ -71,7 +71,7 @@ .col-md-6 %h4 Recent builds served by this Runner - %table.table.builds.runner-builds + %table.table.ci-table.runner-builds %thead %tr %th Build |