diff options
| author | Jacob Schatz <jschatz@gitlab.com> | 2017-03-15 21:21:48 +0000 |
|---|---|---|
| committer | DJ Mountney <david@twkie.net> | 2017-03-20 18:51:36 -0700 |
| commit | c5a9d73ad8a141166d871e551027208014a281c0 (patch) | |
| tree | 2c67e06925166205e40c35588732285260bdecdb /app/views/admin | |
| parent | 153b594c06c994a8c9b4a92e9c5c33c3cdb4e0e0 (diff) | |
| download | gitlab-ce-c5a9d73ad8a141166d871e551027208014a281c0.tar.gz | |
Merge branch 'fix-links-target-blank' into 'security'
Adds rel="noopener noreferrer" to all links with target="_blank"
See merge request !2071
Diffstat (limited to 'app/views/admin')
| -rw-r--r-- | app/views/admin/appearances/_form.html.haml | 2 | ||||
| -rw-r--r-- | app/views/admin/application_settings/_form.html.haml | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/app/views/admin/appearances/_form.html.haml b/app/views/admin/appearances/_form.html.haml index 9175b3d3f96..e403a9da616 100644 --- a/app/views/admin/appearances/_form.html.haml +++ b/app/views/admin/appearances/_form.html.haml @@ -48,7 +48,7 @@ .form-actions = f.submit 'Save', class: 'btn btn-save append-right-10' - if @appearance.persisted? - = link_to 'Preview last save', preview_admin_appearances_path, class: 'btn', target: '_blank' + = link_to 'Preview last save', preview_admin_appearances_path, class: 'btn', target: '_blank', rel: 'noopener noreferrer' - if @appearance.updated_at %span.pull-right diff --git a/app/views/admin/application_settings/_form.html.haml b/app/views/admin/application_settings/_form.html.haml index 00366b0a8c9..3eab065bb9f 100644 --- a/app/views/admin/application_settings/_form.html.haml +++ b/app/views/admin/application_settings/_form.html.haml @@ -404,7 +404,7 @@ Enable Sentry .help-block Sentry is an error reporting and logging tool which is currently not shipped with GitLab, get it here: - %a{ href: 'https://getsentry.com', target: '_blank' } https://getsentry.com + %a{ href: 'https://getsentry.com', target: '_blank', rel: 'noopener noreferrer' } https://getsentry.com .form-group = f.label :sentry_dsn, 'Sentry DSN', class: 'control-label col-sm-2' |