diff options
| author | Thong Kuah <tkuah@gitlab.com> | 2018-12-10 17:05:23 +1300 |
|---|---|---|
| committer | Thong Kuah <tkuah@gitlab.com> | 2018-12-17 09:51:53 +1300 |
| commit | 0e78834bc939980e40aef65b6b51f29293dab6d9 (patch) | |
| tree | 7c028831ce89fa9682e19e8c1143a87a8e6938be /app/views/clusters | |
| parent | 0369e7590428923c0ab2b10a8911f6c60ee93d62 (diff) | |
| download | gitlab-ce-0e78834bc939980e40aef65b6b51f29293dab6d9.tar.gz | |
Move code to presenter
Part of the code such as #show_path is already present on the presenter.
Also avoid having code in two places (helper and presenter)
Sanitize and assert html_safe. Additional layer of defense - on top of
GitLab already requiring group names to be composed of small set of
chars A-Z, - and spaces.
Only link to cluster if user can read cluster
Make clear that arg is a GroupClusterablePresenter
Add more specs for completeness
Diffstat (limited to 'app/views/clusters')
| -rw-r--r-- | app/views/clusters/clusters/_cluster.html.haml | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/app/views/clusters/clusters/_cluster.html.haml b/app/views/clusters/clusters/_cluster.html.haml index 98715bdf655..b89789e9915 100644 --- a/app/views/clusters/clusters/_cluster.html.haml +++ b/app/views/clusters/clusters/_cluster.html.haml @@ -3,7 +3,7 @@ .table-section.section-60 .table-mobile-header{ role: "rowheader" }= s_("ClusterIntegration|Kubernetes cluster") .table-mobile-content - = cluster_group_path_display(cluster, clusterable) + = cluster.item_link(clusterable) - unless cluster.enabled? %span.badge.badge-danger Connection disabled .table-section.section-25 |