diff options
| author | ddavison <ddavison@gitlab.com> | 2019-05-29 16:47:53 -0700 |
|---|---|---|
| committer | ddavison <ddavison@gitlab.com> | 2019-07-10 16:09:43 -0700 |
| commit | 390e0d8906c066996e8bbb14aa5824643f9798f8 (patch) | |
| tree | 8b220d1d2e0770bc96cc958ce624043e1ae0885e /app/views/layouts/header/_default.html.haml | |
| parent | 48fa47e07d54979b70704beb16ea55548f2190c4 (diff) | |
| download | gitlab-ce-390e0d8906c066996e8bbb14aa5824643f9798f8.tar.gz | |
Introduce data-qa-selector to supplant .qa-class
In order to break away from using CSS classes as
our primary method of element identification, we
need to provide the ability to search for data
attributes.
Make Test::Sanity::Selectors now work
Utilize regex to match on literal strings of the element name
Suggest the data-qa-selector pattern vs the qa-
Add data-qa-selector to login page to start
We need a page that is heavily used in order to be
confident that this functionality works. Let's start
with the Login page
Use appropriate HAML data tag practices
Diffstat (limited to 'app/views/layouts/header/_default.html.haml')
| -rw-r--r-- | app/views/layouts/header/_default.html.haml | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/app/views/layouts/header/_default.html.haml b/app/views/layouts/header/_default.html.haml index f9ee6f42e23..36ae24fc4bf 100644 --- a/app/views/layouts/header/_default.html.haml +++ b/app/views/layouts/header/_default.html.haml @@ -5,7 +5,7 @@ - else - search_path_url = search_path -%header.navbar.navbar-gitlab.qa-navbar.navbar-expand-sm.js-navbar +%header.navbar.navbar-gitlab.navbar-expand-sm.js-navbar{ data: { qa_selector: 'navbar' } } %a.sr-only.gl-accessibility{ href: "#content-body", tabindex: "1" } Skip to content .container-fluid .header-content |