summaryrefslogtreecommitdiff
path: root/app/views/projects/commit
diff options
context:
space:
mode:
authorRémy Coutable <remy@rymai.me>2016-10-28 13:37:19 +0000
committerRémy Coutable <remy@rymai.me>2016-10-28 13:37:19 +0000
commit2672f44e25b6b2638b850208a1ef4a97983f28ed (patch)
tree6e204d694ade9efb50dd47e171fb965309eba5fc /app/views/projects/commit
parent4fd015183cdb280083384c69261c2ab5d475a54b (diff)
parentcd3c8e9b1279dce29c5283b54d9b3305be73110f (diff)
downloadgitlab-ce-2672f44e25b6b2638b850208a1ef4a97983f28ed.tar.gz
Merge branch 'clean-up-issue_spec.js' into 'master'
Replace static fixture by generated one in issue_spec.js ## What does this MR do? - clean up `issue_spec.js` - introduce an alternative approach to #19445 - rename `rake teaspoon` to `rake teaspoon:tests` - introduce `rake teaspoon:fixtures` which generates fixtures using RSpec - introduce `rake teaspoon` which runs `rake teaspoon:fixtures` and `rake teaspoon:tests` ## Why was this MR needed? - many duplications - missing existence checks - missing conditions - static fixtures don't match real views ## Reasoning I want to explain some of my decisions here, so that they stay visible for future discussions. ### Why not HAML? - same number of HAML templates as number of fixtures (many input files) - embedded logic less readable - can not be rendered by JavaScript (because of inline Ruby) ### Why RSpec? - real controllers for fixtures - spys available for mocking - easily report failed fixture generations ### Why not magic_lamp? (#19445) - introduces another dependency/tool - needs to run a server concurrently to teaspoon - makes it harder to use a JavaScript test runner - static HTML files serve faster See merge request !6059
Diffstat (limited to 'app/views/projects/commit')
0 files changed, 0 insertions, 0 deletions