diff options
| author | Jason Lee <huacnlee@gmail.com> | 2015-11-12 13:16:35 +0800 |
|---|---|---|
| committer | Jason Lee <huacnlee@gmail.com> | 2015-11-12 13:16:35 +0800 |
| commit | 1974087114f3f365d16547c8a5c3ec2e03a66104 (patch) | |
| tree | bdb754d87349cb4ae7629f537ead5dff8edcebb1 /app/views/projects/notes/_notes_with_form.html.haml | |
| parent | ca25289b78e1b49148438831ad6bf165fa0ce56e (diff) | |
| download | gitlab-ce-1974087114f3f365d16547c8a5c3ec2e03a66104.tar.gz | |
Avoid render edit_form in each notes.
Use RJS to render edit note feature.
Before:
```
Rendered projects/notes/_note.html.haml (27.9ms)
Rendered projects/_zen.html.haml (0.3ms)
Rendered projects/notes/_hints.html.haml (0.7ms)
Rendered projects/_md_preview.html.haml (3.9ms)
Rendered projects/notes/_edit_form.html.haml (6.9ms)
Rendered projects/notes/_note.html.haml (17.7ms)
Rendered projects/_zen.html.haml (0.3ms)
Rendered projects/notes/_hints.html.haml (0.6ms)
Rendered projects/_md_preview.html.haml (3.4ms)
Rendered projects/notes/_edit_form.html.haml (7.0ms)
```
After:
```
Rendered projects/notes/_note.html.haml (13.8ms)
Rendered projects/notes/_note.html.haml (7.1ms)
Rendered projects/notes/_note.html.haml (9.5ms)
Rendered projects/notes/_note.html.haml (8.5ms)
```
This change reduce at least 6ms * N ('N' - number of notes).
Diffstat (limited to 'app/views/projects/notes/_notes_with_form.html.haml')
| -rw-r--r-- | app/views/projects/notes/_notes_with_form.html.haml | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/app/views/projects/notes/_notes_with_form.html.haml b/app/views/projects/notes/_notes_with_form.html.haml index 04222b8f7c4..91cefa6d14d 100644 --- a/app/views/projects/notes/_notes_with_form.html.haml +++ b/app/views/projects/notes/_notes_with_form.html.haml @@ -7,4 +7,4 @@ = render "projects/notes/form", view: params[:view] :javascript - new Notes("#{namespace_project_notes_path(namespace_id: @project.namespace, target_id: @noteable.id, target_type: @noteable.class.name.underscore)}", #{@notes.map(&:id).to_json}, #{Time.now.to_i}, "#{params[:view]}") + window._notes = new Notes("#{namespace_project_notes_path(namespace_id: @project.namespace, target_id: @noteable.id, target_type: @noteable.class.name.underscore)}", #{@notes.map(&:id).to_json}, #{Time.now.to_i}, "#{params[:view]}") |