diff options
| author | Mark Lapierre <mlapierre@gitlab.com> | 2019-01-29 15:56:34 -0500 |
|---|---|---|
| committer | Mark Lapierre <mlapierre@gitlab.com> | 2019-01-29 16:18:04 -0500 |
| commit | 38fcb11f97d02af83cdc5d245e78a3f0d1b146f5 (patch) | |
| tree | dd60f30771b8dbc2c846468dd5604f7d701cd634 /app/views/projects/wikis | |
| parent | fda30abdb2a88f360b20f99f3cefe0850d4e9f18 (diff) | |
| download | gitlab-ce-38fcb11f97d02af83cdc5d245e78a3f0d1b146f5.tar.gz | |
Fix flaky wiki create test
There's an svg on the page that allows you to create a wiki page.
The svg takes a fraction of a second to load after which the
"Create your first page" button shifts up a bit. This can cause
webdriver to miss the hit so we wait for the svg to load before
clicking the button.
Also update the elements used in the test to conform to our best
practice.
And replace `act` with `perform`
Finally, remove the `before` block and `login` method, making the
code slightly simpler.
Diffstat (limited to 'app/views/projects/wikis')
| -rw-r--r-- | app/views/projects/wikis/_form.html.haml | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/app/views/projects/wikis/_form.html.haml b/app/views/projects/wikis/_form.html.haml index 7d8826e540c..d1556dbd077 100644 --- a/app/views/projects/wikis/_form.html.haml +++ b/app/views/projects/wikis/_form.html.haml @@ -16,7 +16,7 @@ .form-group.row .col-sm-12= f.label :title, class: 'control-label-full-width' .col-sm-12 - = f.text_field :title, class: 'form-control', value: @page.title + = f.text_field :title, class: 'form-control qa-wiki-title-textbox', value: @page.title - if @page.persisted? %span.edit-wiki-page-slug-tip = icon('lightbulb-o') @@ -31,7 +31,7 @@ .col-sm-12= f.label :content, class: 'control-label-full-width' .col-sm-12 = render layout: 'projects/md_preview', locals: { url: project_wiki_preview_markdown_path(@project, @page.slug) } do - = render 'projects/zen', f: f, attr: :content, classes: 'note-textarea', placeholder: s_("WikiPage|Write your content or drag files here…") + = render 'projects/zen', f: f, attr: :content, classes: 'note-textarea qa-wiki-content-textarea', placeholder: s_("WikiPage|Write your content or drag files here…") = render 'shared/notes/hints' .clearfix @@ -47,14 +47,14 @@ .form-group.row .col-sm-12= f.label :commit_message, class: 'control-label-full-width' - .col-sm-12= f.text_field :message, class: 'form-control', rows: 18, value: commit_message + .col-sm-12= f.text_field :message, class: 'form-control qa-wiki-message-textbox', rows: 18, value: commit_message .form-actions - if @page && @page.persisted? - = f.submit _("Save changes"), class: 'btn-success btn' + = f.submit _("Save changes"), class: 'btn-success btn qa-save-changes-button' .float-right = link_to _("Cancel"), project_wiki_path(@project, @page), class: 'btn btn-cancel btn-grouped' - else - = f.submit s_("Wiki|Create page"), class: 'btn-success btn' + = f.submit s_("Wiki|Create page"), class: 'btn-success btn qa-create-page-button' .float-right = link_to _("Cancel"), project_wiki_path(@project, :home), class: 'btn btn-cancel' |