diff options
| author | Filipa Lacerda <filipa@gitlab.com> | 2017-11-15 12:04:55 +0000 |
|---|---|---|
| committer | Kamil Trzcinski <ayufan@ayufan.eu> | 2017-12-03 13:36:10 +0100 |
| commit | 10f205f825ad0e7c591eb6d012777bb9026f2ab5 (patch) | |
| tree | c89cfb6f0f82cf9b19cf3d0df16ac7a300c0fcbd /app/views | |
| parent | e25a8e126504177a4543d224b8ba2e61da03ba0e (diff) | |
| download | gitlab-ce-10f205f825ad0e7c591eb6d012777bb9026f2ab5.tar.gz | |
Changes after UX review
Diffstat (limited to 'app/views')
4 files changed, 10 insertions, 9 deletions
diff --git a/app/views/projects/clusters/_advanced_settings.html.haml b/app/views/projects/clusters/_advanced_settings.html.haml index 97532f1e2bd..2b3095eb94b 100644 --- a/app/views/projects/clusters/_advanced_settings.html.haml +++ b/app/views/projects/clusters/_advanced_settings.html.haml @@ -1,10 +1,11 @@ - if can?(current_user, :admin_cluster, @cluster) - .append-bottom-20 - %label.append-bottom-10 - = s_('ClusterIntegration|Google Container Engine') - %p - - link_gke = link_to(s_('ClusterIntegration|Google Container Engine'), @cluster.gke_cluster_url, target: '_blank', rel: 'noopener noreferrer') - = s_('ClusterIntegration|Manage your cluster by visiting %{link_gke}').html_safe % { link_gke: link_gke } + - if @cluster.managed? + .append-bottom-20 + %label.append-bottom-10 + = s_('ClusterIntegration|Google Container Engine') + %p + - link_gke = link_to(s_('ClusterIntegration|Google Container Engine'), @cluster.gke_cluster_url, target: '_blank', rel: 'noopener noreferrer') + = s_('ClusterIntegration|Manage your cluster by visiting %{link_gke}').html_safe % { link_gke: link_gke } .well.form-group %label.text-danger diff --git a/app/views/projects/clusters/_dropdown.html.haml b/app/views/projects/clusters/_dropdown.html.haml index d52359c69c3..46b5fb79fce 100644 --- a/app/views/projects/clusters/_dropdown.html.haml +++ b/app/views/projects/clusters/_dropdown.html.haml @@ -1,6 +1,6 @@ %h4.prepend-top-0= s_('ClusterIntegration|Choose how to set up cluster integration') -.dropdown +.dropdown.clusters-dropdown %button.dropdown-menu-toggle.dropdown-menu-full-width{ type: 'button', data: { toggle: 'dropdown' }, 'aria-haspopup': true, 'aria-expanded': false } %span.dropdown-toggle-text = dropdown_text diff --git a/app/views/projects/clusters/gcp/_show.html.haml b/app/views/projects/clusters/gcp/_show.html.haml index 98456b0d4b8..b387b4f1bc2 100644 --- a/app/views/projects/clusters/gcp/_show.html.haml +++ b/app/views/projects/clusters/gcp/_show.html.haml @@ -34,7 +34,7 @@ .form-group = platform_kubernetes_field.label :namespace, s_('ClusterIntegration|Project namespace (optional, unique)') - = platform_kubernetes_field.text_field :namespace, class: 'form-control', placeholder: s_('ClusterIntegration|Project namespace'), readonly: true + = platform_kubernetes_field.text_field :namespace, class: 'form-control', placeholder: s_('ClusterIntegration|Project namespace') .form-group = field.submit s_('ClusterIntegration|Save changes'), class: 'btn btn-save' diff --git a/app/views/projects/clusters/kubernetes/_show.html.haml b/app/views/projects/clusters/kubernetes/_show.html.haml index 01b15b227ca..31dcb97497e 100644 --- a/app/views/projects/clusters/kubernetes/_show.html.haml +++ b/app/views/projects/clusters/kubernetes/_show.html.haml @@ -2,7 +2,7 @@ %label.append-bottom-10{ for: 'cluster-name' } = s_('ClusterIntegration|Cluster name') .input-group - %input.form-control.cluster-name{ value: @cluster.name, readonly: true } + %input.form-control.cluster-name{ value: @cluster.name } %span.input-group-addon.clipboard-addon = clipboard_button(text: @cluster.name, title: s_('ClusterIntegration|Copy cluster name')) |