diff options
author | Mayra Cabrera <mcabrera@gitlab.com> | 2019-07-05 08:57:26 -0500 |
---|---|---|
committer | Mayra Cabrera <mcabrera@gitlab.com> | 2019-07-10 10:45:40 -0500 |
commit | 1345a954ded8e10dba182b6ea3e823bc234947a9 (patch) | |
tree | b17a7d036488a9207dae8d3ead94f26a27bbf022 /app/workers/object_storage/migrate_uploads_worker.rb | |
parent | b76d4fadd4be35141df659b5ab2ba99b21c79ead (diff) | |
download | gitlab-ce-1345a954ded8e10dba182b6ea3e823bc234947a9.tar.gz |
Add a rubocop for Rails.logger54102-add-rubocop-for-rails-logger
Suggests to use a JSON structured log instead
Related to https://gitlab.com/gitlab-org/gitlab-ce/issues/54102
Diffstat (limited to 'app/workers/object_storage/migrate_uploads_worker.rb')
-rw-r--r-- | app/workers/object_storage/migrate_uploads_worker.rb | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/app/workers/object_storage/migrate_uploads_worker.rb b/app/workers/object_storage/migrate_uploads_worker.rb index 12400d4e025..55ac7cd9b3c 100644 --- a/app/workers/object_storage/migrate_uploads_worker.rb +++ b/app/workers/object_storage/migrate_uploads_worker.rb @@ -37,6 +37,7 @@ module ObjectStorage end end + # rubocop:disable Gitlab/RailsLogger def report!(results) success, failures = results.partition(&:success?) @@ -45,6 +46,7 @@ module ObjectStorage raise MigrationFailures.new(failures.map(&:error)) if failures.any? end + # rubocop:enable Gitlab/RailsLogger def header(success, failures) _("Migrated %{success_count}/%{total_count} files.") % { success_count: success.count, total_count: success.count + failures.count } @@ -98,7 +100,7 @@ module ObjectStorage report!(results) rescue SanityCheckError => e # do not retry: the job is insane - Rails.logger.warn "#{self.class}: Sanity check error (#{e.message})" + Rails.logger.warn "#{self.class}: Sanity check error (#{e.message})" # rubocop:disable Gitlab/RailsLogger end # rubocop: enable CodeReuse/ActiveRecord |