diff options
| author | Thong Kuah <tkuah@gitlab.com> | 2019-06-24 10:36:32 +1200 |
|---|---|---|
| committer | Thong Kuah <tkuah@gitlab.com> | 2019-06-24 10:37:47 +1200 |
| commit | 26b057293d18f35367e39882f3724372b616dc51 (patch) | |
| tree | 6ec358f45ce0e2a03ddc5f839b88915020cc01ac /app/workers | |
| parent | f89a33c9d13db824bb4f4618512d82b6c4e6515a (diff) | |
| download | gitlab-ce-26b057293d18f35367e39882f3724372b616dc51.tar.gz | |
Remove deprecated call in BuildSuccessWorkerremove_create_deployment_from_build_success_worker
We now create_deployment on Ci::Build create.
No need to call create_deployment again
Diffstat (limited to 'app/workers')
| -rw-r--r-- | app/workers/build_success_worker.rb | 12 |
1 files changed, 0 insertions, 12 deletions
diff --git a/app/workers/build_success_worker.rb b/app/workers/build_success_worker.rb index 9a865fea621..ac947f3cf38 100644 --- a/app/workers/build_success_worker.rb +++ b/app/workers/build_success_worker.rb @@ -9,7 +9,6 @@ class BuildSuccessWorker # rubocop: disable CodeReuse/ActiveRecord def perform(build_id) Ci::Build.find_by(id: build_id).try do |build| - create_deployment(build) if build.has_environment? stop_environment(build) if build.stops_environment? end end @@ -18,17 +17,6 @@ class BuildSuccessWorker private ## - # Deprecated: - # As of 11.5, we started creating a deployment record when ci_builds record is created. - # Therefore we no longer need to create a deployment, after a build succeeded. - # We're leaving this code for the transition period, but we can remove this code in 11.6. - def create_deployment(build) - build.create_deployment.try do |deployment| - deployment.succeed - end - end - - ## # TODO: This should be processed in DeploymentSuccessWorker once we started storing `action` value in `deployments` records def stop_environment(build) build.persisted_environment.fire_state_event(:stop) |