diff options
| author | Douwe Maan <douwe@gitlab.com> | 2016-02-18 09:33:21 +0000 |
|---|---|---|
| committer | Douwe Maan <douwe@gitlab.com> | 2016-02-18 09:33:21 +0000 |
| commit | 52a8d1f3c6d8b2f1e9a4551a316c2390786c1650 (patch) | |
| tree | 76faf5d555735a7beeb0c28aeb93a6217b22b3ad /app/workers | |
| parent | 27b732abb159154983424d93d1a68c3d98a65870 (diff) | |
| parent | c110c9bd7f2fabb5c9397291f1f13c6accab70e6 (diff) | |
| download | gitlab-ce-52a8d1f3c6d8b2f1e9a4551a316c2390786c1650.tar.gz | |
Merge branch 'fix/gitpushservice-complexity-issue' into 'master'
Reduce code complexity on GitPushService#execute
Code complexity for gitlab-ce after this has been refactored:
```
27.3: GitPushService#execute
```
This still needs to be merged into `gitlab-ee` presumably with conflicts... Perhaps we should create another issue for doing that?
I left the code sort of similar to what it was... If I could, I would have refactored most of the code into separate classes, etc. as it breaks probably all SOLID principles.
Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/13327
See merge request !2784
Diffstat (limited to 'app/workers')
| -rw-r--r-- | app/workers/post_receive.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/app/workers/post_receive.rb b/app/workers/post_receive.rb index 994b8e8ed38..14d7813412e 100644 --- a/app/workers/post_receive.rb +++ b/app/workers/post_receive.rb @@ -38,7 +38,7 @@ class PostReceive if Gitlab::Git.tag_ref?(ref) GitTagPushService.new.execute(project, @user, oldrev, newrev, ref) else - GitPushService.new.execute(project, @user, oldrev, newrev, ref) + GitPushService.new(project, @user, oldrev: oldrev, newrev: newrev, ref: ref).execute end end end |