summaryrefslogtreecommitdiff
path: root/app
diff options
context:
space:
mode:
authorRémy Coutable <remy@rymai.me>2017-04-03 16:47:18 +0000
committerRémy Coutable <remy@rymai.me>2017-04-03 16:47:18 +0000
commitca6a7f1e9c9296317315249de9b8b3803d1c6ddc (patch)
tree3f4c8c39b4586a480e8989648ecf7d9525acf683 /app
parentb2700e64cce7c9b258e117a995eda8de00a8a988 (diff)
parent0a09925dcef1976970bc2674432f69d46786c38f (diff)
downloadgitlab-ce-ca6a7f1e9c9296317315249de9b8b3803d1c6ddc.tar.gz
Merge branch 'style-proc-cop' into 'master'
Enable Style/Proc cop for rubocop See merge request !10382
Diffstat (limited to 'app')
-rw-r--r--app/mailers/base_mailer.rb4
-rw-r--r--app/models/milestone.rb2
-rw-r--r--app/models/service.rb2
3 files changed, 4 insertions, 4 deletions
diff --git a/app/mailers/base_mailer.rb b/app/mailers/base_mailer.rb
index 79c3c2e62c5..a9b6b33eb5c 100644
--- a/app/mailers/base_mailer.rb
+++ b/app/mailers/base_mailer.rb
@@ -5,8 +5,8 @@ class BaseMailer < ActionMailer::Base
attr_accessor :current_user
helper_method :current_user, :can?
- default from: Proc.new { default_sender_address.format }
- default reply_to: Proc.new { default_reply_to_address.format }
+ default from: proc { default_sender_address.format }
+ default reply_to: proc { default_reply_to_address.format }
def can?
Ability.allowed?(current_user, action, subject)
diff --git a/app/models/milestone.rb b/app/models/milestone.rb
index e85d5709624..ac205b9b738 100644
--- a/app/models/milestone.rb
+++ b/app/models/milestone.rb
@@ -30,7 +30,7 @@ class Milestone < ActiveRecord::Base
validates :title, presence: true, uniqueness: { scope: :project_id }
validates :project, presence: true
- validate :start_date_should_be_less_than_due_date, if: Proc.new { |m| m.start_date.present? && m.due_date.present? }
+ validate :start_date_should_be_less_than_due_date, if: proc { |m| m.start_date.present? && m.due_date.present? }
strip_attributes :title
diff --git a/app/models/service.rb b/app/models/service.rb
index e73f7e5d1a3..54550177744 100644
--- a/app/models/service.rb
+++ b/app/models/service.rb
@@ -25,7 +25,7 @@ class Service < ActiveRecord::Base
belongs_to :project, inverse_of: :services
has_one :service_hook
- validates :project_id, presence: true, unless: Proc.new { |service| service.template? }
+ validates :project_id, presence: true, unless: proc { |service| service.template? }
scope :visible, -> { where.not(type: 'GitlabIssueTrackerService') }
scope :issue_trackers, -> { where(category: 'issue_tracker') }