summaryrefslogtreecommitdiff
path: root/app
diff options
context:
space:
mode:
authorDmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>2018-11-11 16:45:22 +0000
committerDmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>2018-11-11 16:45:22 +0000
commitf69f7a6702f68a14cb29b2686b030f36711cef7f (patch)
tree73e18581c79e0a6f9d2c3d714a56fa3c1794897e /app
parent4aa41d07e16ca03f5f56b7cc5c136d86d51666c2 (diff)
parent269b0e10319569cdfed1282e0af6a9e1c013f2fc (diff)
downloadgitlab-ce-f69f7a6702f68a14cb29b2686b030f36711cef7f.tar.gz
Merge branch 'fix-error-handling-bugs-in-kubernetes-integration' into 'master'
Fix error handling bugs in kubernetes integration See merge request gitlab-org/gitlab-ce!22922
Diffstat (limited to 'app')
-rw-r--r--app/services/clusters/gcp/kubernetes/create_or_update_namespace_service.rb2
-rw-r--r--app/workers/cluster_platform_configure_worker.rb2
2 files changed, 1 insertions, 3 deletions
diff --git a/app/services/clusters/gcp/kubernetes/create_or_update_namespace_service.rb b/app/services/clusters/gcp/kubernetes/create_or_update_namespace_service.rb
index a888fab2789..2b607681082 100644
--- a/app/services/clusters/gcp/kubernetes/create_or_update_namespace_service.rb
+++ b/app/services/clusters/gcp/kubernetes/create_or_update_namespace_service.rb
@@ -16,8 +16,6 @@ module Clusters
configure_kubernetes_token
kubernetes_namespace.save!
- rescue ::Kubeclient::HttpError => err
- raise err unless err.error_code = 404
end
private
diff --git a/app/workers/cluster_platform_configure_worker.rb b/app/workers/cluster_platform_configure_worker.rb
index 68e8335a09d..8f3689f0166 100644
--- a/app/workers/cluster_platform_configure_worker.rb
+++ b/app/workers/cluster_platform_configure_worker.rb
@@ -17,6 +17,6 @@ class ClusterPlatformConfigureWorker
end
rescue ::Kubeclient::HttpError => err
- Rails.logger.error "Failed to create/update Kubernetes Namespace. id: #{kubernetes_namespace.id} message: #{err.message}"
+ Rails.logger.error "Failed to create/update Kubernetes namespace for cluster_id: #{cluster_id} with error: #{err.message}"
end
end