summaryrefslogtreecommitdiff
path: root/app
diff options
context:
space:
mode:
authorDouglas Barbosa Alexandre <dbalexandre@gmail.com>2016-02-22 16:53:07 -0300
committerDouglas Barbosa Alexandre <dbalexandre@gmail.com>2016-02-23 10:43:29 -0300
commit28097398c5087c3ffc7dc6cd63cd7f8304d3dae9 (patch)
tree46dd2f1a06f1ccae484aacef3cf64d31333d1f1d /app
parentf5be56710f0e71042df98f7f7eefbcfed72d912d (diff)
downloadgitlab-ce-28097398c5087c3ffc7dc6cd63cd7f8304d3dae9.tar.gz
Does not raise an error when Todo is already marked as done
Diffstat (limited to 'app')
-rw-r--r--app/controllers/dashboard/todos_controller.rb2
-rw-r--r--app/models/todo.rb2
2 files changed, 2 insertions, 2 deletions
diff --git a/app/controllers/dashboard/todos_controller.rb b/app/controllers/dashboard/todos_controller.rb
index 9ee9039f004..43cf8fa71af 100644
--- a/app/controllers/dashboard/todos_controller.rb
+++ b/app/controllers/dashboard/todos_controller.rb
@@ -15,7 +15,7 @@ class Dashboard::TodosController < Dashboard::ApplicationController
end
def destroy_all
- @todos.each(&:done)
+ @todos.each(&:done!)
respond_to do |format|
format.html { redirect_to dashboard_todos_path, notice: 'All todos were marked as done.' }
diff --git a/app/models/todo.rb b/app/models/todo.rb
index 34d71c1b0d3..5f91991f781 100644
--- a/app/models/todo.rb
+++ b/app/models/todo.rb
@@ -36,7 +36,7 @@ class Todo < ActiveRecord::Base
state_machine :state, initial: :pending do
event :done do
- transition pending: :done
+ transition [:pending, :done] => :done
end
state :pending