summaryrefslogtreecommitdiff
path: root/app
diff options
context:
space:
mode:
authorRobert Speicher <robert@gitlab.com>2017-03-14 19:03:54 +0000
committerRobert Speicher <robert@gitlab.com>2017-03-14 19:03:54 +0000
commit2e0510600ff37b4bf5426a5180fb08c6e88647b8 (patch)
treebbe5572e09b163eefd32ca5e226d126047f0b529 /app
parentfe4a18653be9fa4246d89e367a40bd171776432f (diff)
parent3e29936a15eb2f6c9bc2d92ebf1a67a0cadb916e (diff)
downloadgitlab-ce-2e0510600ff37b4bf5426a5180fb08c6e88647b8.tar.gz
Merge branch '29425-fix-activity-stream-first-line-markdown' into 'master'
Fix first line markdown helper for user profile activity stream Closes #29425 See merge request !9920
Diffstat (limited to 'app')
-rw-r--r--app/helpers/events_helper.rb4
-rw-r--r--app/helpers/gitlab_markdown_helper.rb2
2 files changed, 3 insertions, 3 deletions
diff --git a/app/helpers/events_helper.rb b/app/helpers/events_helper.rb
index 5605393c0c3..fb872a13f74 100644
--- a/app/helpers/events_helper.rb
+++ b/app/helpers/events_helper.rb
@@ -165,8 +165,8 @@ module EventsHelper
sanitize(
text,
- tags: %w(a img b pre code p span),
- attributes: Rails::Html::WhiteListSanitizer.allowed_attributes + ['style']
+ tags: %w(a img gl-emoji b pre code p span),
+ attributes: Rails::Html::WhiteListSanitizer.allowed_attributes + ['style', 'data-name', 'data-unicode-version']
)
end
diff --git a/app/helpers/gitlab_markdown_helper.rb b/app/helpers/gitlab_markdown_helper.rb
index 6d365ea9251..6226cfe25cf 100644
--- a/app/helpers/gitlab_markdown_helper.rb
+++ b/app/helpers/gitlab_markdown_helper.rb
@@ -172,7 +172,7 @@ module GitlabMarkdownHelper
# text hasn't already been truncated, then append "..." to the node contents
# and return true. Otherwise return false.
def truncate_if_block(node, truncated)
- if node.element? && node.description.block? && !truncated
+ if node.element? && node.description&.block? && !truncated
node.inner_html = "#{node.inner_html}..." if node.next_sibling
true
else