summaryrefslogtreecommitdiff
path: root/app
diff options
context:
space:
mode:
authorAndreas Brandl <abrandl@gitlab.com>2018-02-23 20:56:43 +0100
committerAndreas Brandl <abrandl@gitlab.com>2018-03-06 12:53:13 +0100
commitd4d0740e24315e7071f90b3744377b3ca3b5816a (patch)
treef8f2e6cc95617808db683c6e26aad9e251140547 /app
parentebcf3c73bd515a4884961999ef7d33edaba93d57 (diff)
downloadgitlab-ce-d4d0740e24315e7071f90b3744377b3ca3b5816a.tar.gz
Cache project/user combinations.
Diffstat (limited to 'app')
-rw-r--r--app/models/user_contributed_projects.rb22
1 files changed, 19 insertions, 3 deletions
diff --git a/app/models/user_contributed_projects.rb b/app/models/user_contributed_projects.rb
index 846d77f3c69..e051e75af1d 100644
--- a/app/models/user_contributed_projects.rb
+++ b/app/models/user_contributed_projects.rb
@@ -5,9 +5,25 @@ class UserContributedProjects < ActiveRecord::Base
validates :project, presence: true
validates :user, presence: true
+ CACHE_EXPIRY_TIME = 1.day
+
def self.track(event)
- find_or_create_by!(project: event.project, user: event.author)
- rescue ActiveRecord::RecordNotUnique
- retry
+ attributes = {project_id: event.project_id, user_id: event.author_id}
+
+ cached_exists?(attributes) do
+ begin
+ find_or_create_by!(attributes)
+ true # not caching the whole record here for now
+ rescue ActiveRecord::RecordNotUnique
+ retry
+ end
+ end
+ end
+
+ private
+
+ def self.cached_exists?(project_id:, user_id:, &block)
+ cache_key = "user_contributed_projects:#{project_id}:#{user_id}"
+ Rails.cache.fetch(cache_key, expires_in: CACHE_EXPIRY_TIME, &block)
end
end