MR on fork: Email fixes, style fixes

-Removed many extra spaces I added
-Fixed email templates to be consistent/better looking

GITLAB-894, GITLAB-895, (GITLAB-858)

Change-Id: I35c1a8e0e22af7de26d54e5c3da987fa7bb3921e

7 files changed, 17 insertions, 23 deletions

diff --git a/app/models/merge_request.rb b/app/models/merge_request.rb
index b5d1a34ec31..28ea8499fc0 100644
--- a/app/models/merge_request.rb
+++ b/app/models/merge_request.rb
@@ -194,7 +194,6 @@ class MergeRequest < ActiveRecord::Base
     commits
   end
 
-
   def merge!(user_id)
     self.author_id_of_changes = user_id
     self.merge
@@ -222,7 +221,6 @@ class MergeRequest < ActiveRecord::Base
     Gitlab::Satellite::MergeAction.new(current_user, self).diff_in_satellite
   end
 
-
   # Returns the commit as a series of email patches.
   #
   # see "git format-patch"
diff --git a/app/models/note.rb b/app/models/note.rb
index 0175430be4d..6b119f00235 100644
--- a/app/models/note.rb
+++ b/app/models/note.rb
@@ -52,11 +52,11 @@ class Note < ActiveRecord::Base
 
   def self.create_status_change_note(noteable, project, author, status)
     create({
-               noteable: noteable,
-               project: project,
-               author: author,
-               note: "_Status changed to #{status}_"
-           }, without_protection: true)
+      noteable: noteable,
+      project: project,
+      author: author,
+      note: "_Status changed to #{status}_"
+    }, without_protection: true)
   end
 
   def commit_author
@@ -97,7 +97,7 @@ class Note < ActiveRecord::Base
   # otherwise false is returned
   def downvote?
     votable? && (note.start_with?('-1') ||
-        note.start_with?(':-1:')
+      note.start_with?(':-1:')
     )
   end
 
@@ -136,8 +136,8 @@ class Note < ActiveRecord::Base
     else
       super
     end
-      # Temp fix to prevent app crash
-      # if note commit id doesn't exist
+  # Temp fix to prevent app crash
+  # if note commit id doesn't exist
   rescue
     nil
   end
@@ -146,7 +146,7 @@ class Note < ActiveRecord::Base
   # otherwise false is returned
   def upvote?
     votable? && (note.start_with?('+1') ||
-        note.start_with?(':+1:')
+      note.start_with?(':+1:')
     )
   end
 
diff --git a/app/views/merge_requests/update_branches.js.haml b/app/views/merge_requests/update_branches.js.haml
index c9171622669..7324aa89a5e 100644
--- a/app/views/merge_requests/update_branches.js.haml
+++ b/app/views/merge_requests/update_branches.js.haml
@@ -1,8 +1,4 @@
 :plain
   $(".target_branch").html("#{escape_javascript(options_for_select(@target_branches))}");
   $(".target_branch").trigger("liszt:updated");
-  $(".mr_target_commit").html("");
-
-
-
-
+  $(".mr_target_commit").html("");
\ No newline at end of file
diff --git a/app/views/notify/closed_merge_request_email.text.haml b/app/views/notify/closed_merge_request_email.text.haml
index 1c92e004ff6..7cf066339c3 100644
--- a/app/views/notify/closed_merge_request_email.text.haml
+++ b/app/views/notify/closed_merge_request_email.text.haml
@@ -2,7 +2,7 @@
 
 Merge Request url: #{project_merge_request_url(@merge_request.target_project, @merge_request)}
 
-Project:Branches: #{@merge_request.source_project.path_with_namespace}/#{@merge_request.source_branch} - #{@merge_request.target_project.path_with_namespace}#{@merge_request.target_branch}
+Project:Branches: #{@merge_request.source_project.path_with_namespace}:#{@merge_request.source_branch} to #{@merge_request.target_project.path_with_namespace}:#{@merge_request.target_branch}
 
 Author: #{@merge_request.author_name}
 Assignee: #{@merge_request.assignee_name}
diff --git a/app/views/notify/merged_merge_request_email.text.haml b/app/views/notify/merged_merge_request_email.text.haml
index 5f19473fae0..ca18d8f30e5 100644
--- a/app/views/notify/merged_merge_request_email.text.haml
+++ b/app/views/notify/merged_merge_request_email.text.haml
@@ -2,7 +2,7 @@
 
 Merge Request Url: #{project_merge_request_url(@merge_request.target_project, @merge_request)}
 
-Project:Branches: #{@merge_request.source_project.path_with_namespace}/#{@merge_request.source_branch} - #{@merge_request.target_project.path_with_namespace}#{@merge_request.target_branch}
+Project:Branches: #{@merge_request.source_project.path_with_namespace}:#{@merge_request.source_branch} to #{@merge_request.target_project.path_with_namespace}:#{@merge_request.target_branch}
 
 Author: #{@merge_request.author_name}
 Assignee: #{@merge_request.assignee_name}
diff --git a/app/views/notify/new_merge_request_email.html.haml b/app/views/notify/new_merge_request_email.html.haml
index fc4ffba1102..72546e00b15 100644
--- a/app/views/notify/new_merge_request_email.html.haml
+++ b/app/views/notify/new_merge_request_email.html.haml
@@ -3,7 +3,7 @@
 %p
   = link_to_gfm truncate(@merge_request.title, length: 40), project_merge_request_url(@merge_request.target_project, @merge_request)
 %p
-  Project:Branches: #{@merge_request.source_project.path_with_namespace}/#{@merge_request.source_branch} - #{@merge_request.target_project.path_with_namespace}#{@merge_request.target_branch}
+  Project:Branches: #{@merge_request.source_project.path_with_namespace}:#{@merge_request.source_branch} &rarr; #{@merge_request.target_project.path_with_namespace}:#{@merge_request.target_branch}
 %p
   Assignee: #{@merge_request.author_name} &rarr; #{@merge_request.assignee_name}
 
diff --git a/app/views/projects/merge_requests/_form.html.haml b/app/views/projects/merge_requests/_form.html.haml
index 558c17eb0f6..7d43dc93eea 100644
--- a/app/views/projects/merge_requests/_form.html.haml
+++ b/app/views/projects/merge_requests/_form.html.haml
@@ -71,12 +71,12 @@
   $.get("#{branch_from_project_merge_requests_path(@source_project)}", {ref: source_branch.val() });
   $.get("#{branch_to_project_merge_requests_path(@source_project)}", {target_project_id: target_project.val(),ref: target_branch.val() });
 
-  target_project.live("change", function() {
+  target_project.on("change", function() {
     $.get("#{update_branches_project_merge_requests_path(@source_project)}", {target_project_id:  $(this).val() });
   });
-  source_branch.live("change", function() {
+  source_branch.on("change", function() {
     $.get("#{branch_from_project_merge_requests_path(@source_project)}", {ref: $(this).val() });
   });
-  target_branch.live("change", function() {
+  target_branch.on("change", function() {
     $.get("#{branch_to_project_merge_requests_path(@source_project)}", {target_project_id: target_project.val(),ref: $(this).val() });
-  });
\ No newline at end of file
+  });