Fix the way hostname is validated with the knative app

2 files changed, 8 insertions, 4 deletions

diff --git a/app/assets/javascripts/clusters/stores/clusters_store.js b/app/assets/javascripts/clusters/stores/clusters_store.js
index 26566b60ba6..f4a016f3ef1 100644
--- a/app/assets/javascripts/clusters/stores/clusters_store.js
+++ b/app/assets/javascripts/clusters/stores/clusters_store.js
@@ -52,7 +52,7 @@ export default class ClusterStore {
           statusReason: null,
           requestStatus: null,
           requestReason: null,
-          hostname: null
+          hostname: null,
         },
       },
     };
@@ -102,7 +102,9 @@ export default class ClusterStore {
             ? `jupyter.${this.state.applications.ingress.externalIp}.nip.io`
             : '');
       } else if (appId === KNATIVE) {
-        this.state.applications.knative.hostname = serverAppEntry.hostname ? serverAppEntry.hostname : null;
+        this.state.applications.knative.hostname = serverAppEntry.hostname
+          ? serverAppEntry.hostname
+          : null;
       }
     });
   }
diff --git a/app/models/clusters/applications/knative.rb b/app/models/clusters/applications/knative.rb
index ecb42f6011e..d5cf3a4bb07 100644
--- a/app/models/clusters/applications/knative.rb
+++ b/app/models/clusters/applications/knative.rb
@@ -20,8 +20,6 @@ module Clusters
       default_value_for :version, VERSION
       default_value_for :hostname, nil
 
-      validates :hostname, presence: true
-
       def chart
         'knative/knative'
       end
@@ -31,6 +29,10 @@ module Clusters
       end
 
       def install_command
+        if hostname.nil?
+          raise 'Hostname is required'
+        end
+
         Gitlab::Kubernetes::Helm::InstallCommand.new(
           name: name,
           version: VERSION,