summaryrefslogtreecommitdiff
path: root/app
diff options
context:
space:
mode:
authorRegis <boudinot.regis@yahoo.com>2017-05-04 06:24:50 -0600
committerRegis <boudinot.regis@yahoo.com>2017-05-04 06:24:50 -0600
commit05c409d28eaacde527a9260a1828fcd2b720a93c (patch)
tree945b6b12f4292e33e49135667bd2c65c90ed4499 /app
parent7a37ada12f8c2dc033594fecddf63345f1addf37 (diff)
downloadgitlab-ce-05c409d28eaacde527a9260a1828fcd2b720a93c.tar.gz
use nextTick and cache timeAgoEl
Diffstat (limited to 'app')
-rw-r--r--app/assets/javascripts/issue_show/issue_title_description.vue20
1 files changed, 10 insertions, 10 deletions
diff --git a/app/assets/javascripts/issue_show/issue_title_description.vue b/app/assets/javascripts/issue_show/issue_title_description.vue
index 8d2ef39040b..0593d95cf40 100644
--- a/app/assets/javascripts/issue_show/issue_title_description.vue
+++ b/app/assets/javascripts/issue_show/issue_title_description.vue
@@ -1,4 +1,5 @@
<script>
+import Vue from 'vue';
import Visibility from 'visibilityjs';
import Poll from './../lib/utils/poll';
import Service from './services/index';
@@ -37,13 +38,13 @@ export default {
return {
poll,
apiData: {},
- timeoutId: null,
title: null,
titleText: '',
+ tasks: '0 of 0',
description: null,
descriptionText: '',
descriptionChange: false,
- tasks: '0 of 0',
+ timeAgoEl: $('.issue_edited_ago'),
titleEl: document.querySelector('title'),
};
},
@@ -86,18 +87,18 @@ export default {
this.titleEl.innerText = currentTabTitleScope.join('ยท');
},
animate(title, description, elementsToVisualize) {
- this.timeoutId = setTimeout(() => {
- this.title = title;
- this.description = description;
- this.setTabTitle();
+ this.title = title;
+ this.description = description;
+ this.setTabTitle();
+ Vue.nextTick(() => {
elementsToVisualize.forEach((element) => {
if (element) {
element.classList.remove('issue-realtime-pre-pulse');
element.classList.add('issue-realtime-trigger-pulse');
}
});
- }, 0);
+ });
},
triggerAnimation() {
// always reset to false before checking the change
@@ -124,10 +125,9 @@ export default {
},
updateEditedTimeAgo() {
const toolTipTime = gl.utils.formatDate(this.apiData.updated_at);
- const $timeAgoNode = $('.issue_edited_ago');
- $timeAgoNode.attr('datetime', this.apiData.updated_at);
- $timeAgoNode.attr('data-original-title', toolTipTime);
+ this.timeAgoEl.attr('datetime', this.apiData.updated_at);
+ this.timeAgoEl.attr('data-original-title', toolTipTime);
},
},
computed: {