summaryrefslogtreecommitdiff
path: root/app
diff options
context:
space:
mode:
authorFatih Acet <acetfatih@gmail.com>2016-10-27 13:12:50 +0000
committerFatih Acet <acetfatih@gmail.com>2016-10-27 13:12:50 +0000
commit337c5ded7ed46f69efc9d1c47114d3b5a18dceba (patch)
tree1911fee59fa3ea15a441645cf82aec7a79b704ec /app
parentb5797168ec529c179342b8c292c2b52f0cbe41ee (diff)
parent980819f8bb6b90018db285f09b07e25d26d1ed3a (diff)
downloadgitlab-ce-337c5ded7ed46f69efc9d1c47114d3b5a18dceba.tar.gz
Merge branch '23868-build-graph-tooltips' into 'master'
Remove tooltips from build nodes Before: <img src="/uploads/48441dccfe39c5eb1da3dbb9a26e6bd2/Screen_Shot_2016-10-26_at_2.43.46_PM.png" width="400px"> After: <img src="/uploads/d72b2ad4603c964283e155e5a2b053fe/Screen_Shot_2016-10-26_at_2.43.31_PM.png" width="400px"> Closes #23868 See merge request !7128
Diffstat (limited to 'app')
-rw-r--r--app/views/projects/ci/builds/_build_pipeline.html.haml7
-rw-r--r--app/views/projects/commit/_pipeline_status_group.html.haml2
-rw-r--r--app/views/projects/generic_commit_statuses/_generic_commit_status_pipeline.html.haml4
3 files changed, 6 insertions, 7 deletions
diff --git a/app/views/projects/ci/builds/_build_pipeline.html.haml b/app/views/projects/ci/builds/_build_pipeline.html.haml
index 55965172d3f..93dca81e6f9 100644
--- a/app/views/projects/ci/builds/_build_pipeline.html.haml
+++ b/app/views/projects/ci/builds/_build_pipeline.html.haml
@@ -1,14 +1,13 @@
- is_playable = subject.playable? && can?(current_user, :update_build, @project)
- if is_playable
= link_to play_namespace_project_build_path(subject.project.namespace, subject.project, subject, return_to: request.original_url), method: :post, data: { toggle: 'tooltip', title: "#{subject.name} - play", container: '.pipeline-graph', placement: 'bottom' } do
- = render_status_with_link('build', 'play')
+ = ci_icon_for_status('play')
.ci-status-text= subject.name
- elsif can?(current_user, :read_build, @project)
= link_to namespace_project_build_path(subject.project.namespace, subject.project, subject), data: { toggle: 'tooltip', title: "#{subject.name} - #{subject.status}", container: '.pipeline-graph', placement: 'bottom' } do
%span.ci-status-icon
- = render_status_with_link('build', subject.status)
+ = ci_icon_for_status(subject.status)
.ci-status-text= subject.name
- else
%span.ci-status-icon
- = render_status_with_link('build', subject.status)
- = ci_icon_for_status(subject.status)
+ = ci_icon_for_status(subject.status)
diff --git a/app/views/projects/commit/_pipeline_status_group.html.haml b/app/views/projects/commit/_pipeline_status_group.html.haml
index f2d71fa6989..18daa2ee693 100644
--- a/app/views/projects/commit/_pipeline_status_group.html.haml
+++ b/app/views/projects/commit/_pipeline_status_group.html.haml
@@ -1,7 +1,7 @@
- group_status = CommitStatus.where(id: subject).status
%button.dropdown-menu-toggle.has-tooltip{ type: 'button', data: { toggle: 'dropdown', title: "#{name} - #{group_status}" } }
%span.ci-status-icon
- = render_status_with_link('build', group_status)
+ = ci_icon_for_status(group_status)
%span.ci-status-text
= name
%span.badge= subject.size
diff --git a/app/views/projects/generic_commit_statuses/_generic_commit_status_pipeline.html.haml b/app/views/projects/generic_commit_statuses/_generic_commit_status_pipeline.html.haml
index c45b73e4225..1c457244a7a 100644
--- a/app/views/projects/generic_commit_statuses/_generic_commit_status_pipeline.html.haml
+++ b/app/views/projects/generic_commit_statuses/_generic_commit_status_pipeline.html.haml
@@ -2,9 +2,9 @@
- if subject.target_url
= link_to subject.target_url do
%span.ci-status-icon
- = render_status_with_link('commit status', subject.status)
+ = ci_icon_for_status(subject.status)
%span.ci-status-text= subject.name
- else
%span.ci-status-icon
- = render_status_with_link('commit status', subject.status)
+ = ci_icon_for_status(subject.status)
%span.ci-status-text= subject.name