Constants in Events looks good now

5 files changed, 26 insertions, 26 deletions

diff --git a/app/models/event.rb b/app/models/event.rb
index 97b1e3306aa..18422e192a4 100644
--- a/app/models/event.rb
+++ b/app/models/event.rb
@@ -20,15 +20,15 @@ class Event < ActiveRecord::Base
 
   default_scope where("author_id IS NOT NULL")
 
-  Created   = 1
-  Updated   = 2
-  Closed    = 3
-  Reopened  = 4
-  Pushed    = 5
-  Commented = 6
-  Merged    = 7
-  Joined    = 8 # User joined project
-  Left      = 9 # User left project
+  CREATED   = 1
+  UPDATED   = 2
+  CLOSED    = 3
+  REOPENED  = 4
+  PUSHED    = 5
+  COMMENTED = 6
+  MERGED    = 7
+  JOINED    = 8 # User joined project
+  LEFT      = 9 # User left project
 
   delegate :name, :email, to: :author, prefix: true, allow_nil: true
   delegate :title, to: :issue, prefix: true, allow_nil: true
@@ -43,15 +43,15 @@ class Event < ActiveRecord::Base
 
   # Scopes
   scope :recent, -> { order("created_at DESC") }
-  scope :code_push, -> { where(action: Pushed) }
+  scope :code_push, -> { where(action: PUSHED) }
   scope :in_projects, ->(project_ids) { where(project_id: project_ids).recent }
 
   class << self
     def determine_action(record)
       if [Issue, MergeRequest].include? record.class
-        Event::Created
+        Event::CREATED
       elsif record.kind_of? Note
-        Event::Commented
+        Event::COMMENTED
       end
     end
   end
@@ -79,19 +79,19 @@ class Event < ActiveRecord::Base
   end
 
   def push?
-    action == self.class::Pushed && valid_push?
+    action == self.class::PUSHED && valid_push?
   end
 
   def merged?
-    action == self.class::Merged
+    action == self.class::MERGED
   end
 
   def closed?
-    action == self.class::Closed
+    action == self.class::CLOSED
   end
 
   def reopened?
-    action == self.class::Reopened
+    action == self.class::REOPENED
   end
 
   def milestone?
@@ -111,11 +111,11 @@ class Event < ActiveRecord::Base
   end
 
   def joined?
-    action == Joined
+    action == JOINED
   end
 
   def left?
-    action == Left
+    action == LEFT
   end
 
   def membership_changed?
diff --git a/app/models/merge_request.rb b/app/models/merge_request.rb
index b6ea85f6507..345b8d6e07d 100644
--- a/app/models/merge_request.rb
+++ b/app/models/merge_request.rb
@@ -133,11 +133,11 @@ class MergeRequest < ActiveRecord::Base
   end
 
   def merge_event
-    self.project.events.where(target_id: self.id, target_type: "MergeRequest", action: Event::Merged).last
+    self.project.events.where(target_id: self.id, target_type: "MergeRequest", action: Event::MERGED).last
   end
 
   def closed_event
-    self.project.events.where(target_id: self.id, target_type: "MergeRequest", action: Event::Closed).last
+    self.project.events.where(target_id: self.id, target_type: "MergeRequest", action: Event::CLOSED).last
   end
 
   def commits
@@ -184,7 +184,7 @@ class MergeRequest < ActiveRecord::Base
     self.mark_as_merged!
     Event.create(
       project: self.project,
-      action: Event::Merged,
+      action: Event::MERGED,
       target_id: self.id,
       target_type: "MergeRequest",
       author_id: user_id
diff --git a/app/models/project.rb b/app/models/project.rb
index acc1b8d2328..15b2d858b62 100644
--- a/app/models/project.rb
+++ b/app/models/project.rb
@@ -103,7 +103,7 @@ class Project < ActiveRecord::Base
     end
 
     def with_push
-      includes(:events).where('events.action = ?', Event::Pushed)
+      includes(:events).where('events.action = ?', Event::PUSHED)
     end
 
     def active
@@ -336,7 +336,7 @@ class Project < ActiveRecord::Base
   def observe_push(data)
     Event.create(
       project: self,
-      action: Event::Pushed,
+      action: Event::PUSHED,
       data: data,
       author_id: data[:user_id]
     )
diff --git a/app/observers/activity_observer.rb b/app/observers/activity_observer.rb
index c188e5720ac..b568bb6b763 100644
--- a/app/observers/activity_observer.rb
+++ b/app/observers/activity_observer.rb
@@ -26,7 +26,7 @@ class ActivityObserver < ActiveRecord::Observer
         project: record.project,
         target_id: record.id,
         target_type: record.class.name,
-        action: (record.closed ? Event::Closed : Event::Reopened),
+        action: (record.closed ? Event::CLOSED : Event::REOPENED),
         author_id: record.author_id_of_changes
       )
     end
diff --git a/app/observers/users_project_observer.rb b/app/observers/users_project_observer.rb
index b969d6a13ef..66b421753f0 100644
--- a/app/observers/users_project_observer.rb
+++ b/app/observers/users_project_observer.rb
@@ -7,7 +7,7 @@ class UsersProjectObserver < ActiveRecord::Observer
   def after_create(users_project)
     Event.create(
       project_id: users_project.project.id,
-      action: Event::Joined,
+      action: Event::JOINED,
       author_id: users_project.user.id
     )
   end
@@ -15,7 +15,7 @@ class UsersProjectObserver < ActiveRecord::Observer
   def after_destroy(users_project)
     Event.create(
       project_id: users_project.project.id,
-      action: Event::Left,
+      action: Event::LEFT,
       author_id: users_project.user.id
     )
   end