diff options
author | Phil Hughes <me@iamphill.com> | 2019-01-28 17:33:20 +0000 |
---|---|---|
committer | Phil Hughes <me@iamphill.com> | 2019-01-28 17:33:20 +0000 |
commit | 958a819fce709419c0be76cec8a20c8e8417ab84 (patch) | |
tree | 3495af91b52dc8ff300d42d73b449b4f7e53af60 /app | |
parent | a24551964180614bb9b19417763996043edba25f (diff) | |
parent | 3af7723fcde7d32986ae4a9e104a893cf0167745 (diff) | |
download | gitlab-ce-958a819fce709419c0be76cec8a20c8e8417ab84.tar.gz |
Merge branch 'refactor/56369-extract-jump-to-next-discussion-button' into 'master'
Refactor/56369 extract jump to next discussion button
Closes #56369
See merge request gitlab-org/gitlab-ce!24506
Diffstat (limited to 'app')
-rw-r--r-- | app/assets/javascripts/notes/components/discussion_jump_to_next_button.vue | 28 | ||||
-rw-r--r-- | app/assets/javascripts/notes/components/noteable_discussion.vue | 16 |
2 files changed, 34 insertions, 10 deletions
diff --git a/app/assets/javascripts/notes/components/discussion_jump_to_next_button.vue b/app/assets/javascripts/notes/components/discussion_jump_to_next_button.vue new file mode 100644 index 00000000000..07a5bda6bcb --- /dev/null +++ b/app/assets/javascripts/notes/components/discussion_jump_to_next_button.vue @@ -0,0 +1,28 @@ +<script> +import icon from '~/vue_shared/components/icon.vue'; +import { GlTooltipDirective } from '@gitlab/ui'; + +export default { + name: 'JumpToNextDiscussionButton', + components: { + icon, + }, + directives: { + GlTooltip: GlTooltipDirective, + }, +}; +</script> + +<template> + <div class="btn-group" role="group"> + <button + ref="button" + v-gl-tooltip + class="btn btn-default discussion-next-btn" + :title="s__('MergeRequests|Jump to next unresolved discussion')" + @click="$emit('onClick')" + > + <icon name="comment-next" /> + </button> + </div> +</template> diff --git a/app/assets/javascripts/notes/components/noteable_discussion.vue b/app/assets/javascripts/notes/components/noteable_discussion.vue index 1a9723de856..8add7278f9b 100644 --- a/app/assets/javascripts/notes/components/noteable_discussion.vue +++ b/app/assets/javascripts/notes/components/noteable_discussion.vue @@ -23,6 +23,7 @@ import autosave from '../mixins/autosave'; import noteable from '../mixins/noteable'; import resolvable from '../mixins/resolvable'; import discussionNavigation from '../mixins/discussion_navigation'; +import jumpToNextDiscussionButton from './discussion_jump_to_next_button.vue'; export default { name: 'NoteableDiscussion', @@ -34,6 +35,7 @@ export default { noteSignedOutWidget, noteEditedText, noteForm, + jumpToNextDiscussionButton, toggleRepliesWidget, placeholderNote, placeholderSystemNote, @@ -476,16 +478,10 @@ Please check your network connection and try again.`; <icon name="issue-new" /> </a> </div> - <div v-if="shouldShowJumpToNextDiscussion" class="btn-group" role="group"> - <button - v-gl-tooltip - class="btn btn-default discussion-next-btn" - title="Jump to next unresolved discussion" - @click="jumpToNextDiscussion" - > - <icon name="comment-next" /> - </button> - </div> + <jump-to-next-discussion-button + v-if="shouldShowJumpToNextDiscussion" + @onClick="jumpToNextDiscussion" + /> </div> </div> </template> |