Handle formats at the controller level in Projects::BoardListsController

1 files changed, 18 insertions, 22 deletions

diff --git a/app/controllers/projects/board_lists_controller.rb b/app/controllers/projects/board_lists_controller.rb
index ab3a4f71bb9..0969fef6999 100644
--- a/app/controllers/projects/board_lists_controller.rb
+++ b/app/controllers/projects/board_lists_controller.rb
@@ -1,48 +1,40 @@
 class Projects::BoardListsController < Projects::ApplicationController
+  respond_to :json
+
   rescue_from ActiveRecord::RecordNotFound, with: :record_not_found
 
   def create
     list = Boards::Lists::CreateService.new(project, list_params).execute
 
-    respond_to do |format|
-      if list.valid?
-        format.json { render json: list.as_json(only: [:id, :list_type, :position], methods: [:title], include: { label: { only: [:id, :title, :color] } }) }
-      else
-        format.json { render json: list.errors, status: :unprocessable_entity }
-      end
+    if list.valid?
+      render json: list.as_json(only: [:id, :list_type, :position], methods: [:title], include: { label: { only: [:id, :title, :color] } })
+    else
+      render json: list.errors, status: :unprocessable_entity
     end
   end
 
   def update
     service = Boards::Lists::MoveService.new(project, move_params)
 
-    respond_to do |format|
-      if service.execute
-        format.json { head :ok }
-      else
-        format.json { head :unprocessable_entity }
-      end
+    if service.execute
+      head :ok
+    else
+      head :unprocessable_entity
     end
   end
 
   def destroy
     service = Boards::Lists::DestroyService.new(project, params)
 
-    respond_to do |format|
-      if service.execute
-        format.json { head :ok }
-      else
-        format.json { head :unprocessable_entity }
-      end
+    if service.execute
+      head :ok
+    else
+      head :unprocessable_entity
     end
   end
 
   private
 
-  def record_not_found(exception)
-    render json: { error: exception.message }, status: :not_found
-  end
-
   def list_params
     params.require(:list).permit(:label_id)
   end
@@ -50,4 +42,8 @@ class Projects::BoardListsController < Projects::ApplicationController
   def move_params
     params.require(:list).permit(:position).merge(id: params[:id])
   end
+
+  def record_not_found(exception)
+    render json: { error: exception.message }, status: :not_found
+  end
 end