summaryrefslogtreecommitdiff
path: root/app
diff options
context:
space:
mode:
authorBrandon Labuschagne <blabuschagne@gitlab.com>2019-05-15 15:35:09 +0200
committerBrandon Labuschagne <blabuschagne@gitlab.com>2019-05-15 15:35:09 +0200
commit2d612aaa43636f8b623695967d8be7a085b03e90 (patch)
treeabd29f544c3b0f262c301ab8f413b04f5cdfca54 /app
parent3d0b6823ab63652acf9703560f6ad4b267b88034 (diff)
downloadgitlab-ce-2d612aaa43636f8b623695967d8be7a085b03e90.tar.gz
Refactor split link after i18n
Diffstat (limited to 'app')
-rw-r--r--app/assets/javascripts/notes.js19
1 files changed, 13 insertions, 6 deletions
diff --git a/app/assets/javascripts/notes.js b/app/assets/javascripts/notes.js
index bc5c7d9f16b..d21982721ed 100644
--- a/app/assets/javascripts/notes.js
+++ b/app/assets/javascripts/notes.js
@@ -35,7 +35,7 @@ import {
} from './lib/utils/common_utils';
import imageDiffHelper from './image_diff/helpers/index';
import { localTimeAgo } from './lib/utils/datetime_utility';
-import { s__, __ } from './locale';
+import { sprintf, s__, __ } from './locale';
window.autosize = Autosize;
@@ -1261,12 +1261,19 @@ export default class Notes {
putConflictEditWarningInPlace(noteEntity, $note) {
if ($note.find('.js-conflict-edit-warning').length === 0) {
+ const open_link = `<a href="#note_${
+ noteEntity.id
+ }" target="_blank" rel="noopener noreferrer">`;
const $alert = $(`<div class="js-conflict-edit-warning alert alert-danger">
- ${__('This comment has changed since you started editing, please review the')}
- <a href="#note_${noteEntity.id}" target="_blank" rel="noopener noreferrer">
- ${__('updated comment')}
- </a>
- ${__('to ensure information is not lost')}
+ ${sprintf(
+ s__(
+ 'Notes|This comment has changed since you started editing, please review the %{open_link}updated comment%{close_link} to ensure information is not lost',
+ ),
+ {
+ open_link,
+ close_link: '</a>',
+ },
+ )}
</div>`);
$alert.insertAfter($note.find('.note-text'));
}