summaryrefslogtreecommitdiff
path: root/app
diff options
context:
space:
mode:
authorJose Ivan Vargas <jvargas@gitlab.com>2017-01-03 12:55:36 -0600
committerJose Ivan Vargas <jvargas@gitlab.com>2017-01-03 12:55:36 -0600
commit8f4f04c2386f29ae6817d72b65b50782b20e4a5e (patch)
tree74f1ebafcd8d8ea09976d98e5c11342ea95a77bd /app
parentf243f1b2b9c17077070fa25afa6b40e26f656f33 (diff)
downloadgitlab-ce-8f4f04c2386f29ae6817d72b65b50782b20e4a5e.tar.gz
Fixed es6 lint errors, and reverted a change to a helper
Diffstat (limited to 'app')
-rw-r--r--app/assets/javascripts/member_expiration_date.js.es611
-rw-r--r--app/helpers/selects_helper.rb2
-rw-r--r--app/views/projects/group_links/_index.html.haml2
-rw-r--r--app/views/projects/project_members/_new_project_member.html.haml2
4 files changed, 8 insertions, 9 deletions
diff --git a/app/assets/javascripts/member_expiration_date.js.es6 b/app/assets/javascripts/member_expiration_date.js.es6
index e879a70958a..c9c548a490e 100644
--- a/app/assets/javascripts/member_expiration_date.js.es6
+++ b/app/assets/javascripts/member_expiration_date.js.es6
@@ -1,30 +1,29 @@
-/* eslint-disable func-names, space-before-function-paren, vars-on-top, no-var, object-shorthand, comma-dangle, max-len */
(() => {
// Add datepickers to all `js-access-expiration-date` elements. If those elements are
// children of an element with the `clearable-input` class, and have a sibling
// `js-clear-input` element, then show that element when there is a value in the
// datepicker, and make clicking on that element clear the field.
//
+ window.gl = window.gl || {};
gl.MemberExpirationDate = (selector = '.js-access-expiration-date') => {
function toggleClearInput() {
$(this).closest('.clearable-input').toggleClass('has-value', $(this).val() !== '');
}
-
- var inputs = $(selector);
+ const inputs = $(selector);
inputs.datepicker({
dateFormat: 'yy-mm-dd',
minDate: 1,
- onSelect: function () {
+ onSelect: () => {
$(this).trigger('change');
toggleClearInput.call(this);
- }
+ },
});
inputs.next('.js-clear-input').on('click', (event) => {
event.preventDefault();
- var input = $(this).closest('.clearable-input').find(selector);
+ const input = $(this).closest('.clearable-input').find(selector);
input.datepicker('setDate', null)
.trigger('change');
toggleClearInput.call(input);
diff --git a/app/helpers/selects_helper.rb b/app/helpers/selects_helper.rb
index e20b3f7de07..8706876ae4a 100644
--- a/app/helpers/selects_helper.rb
+++ b/app/helpers/selects_helper.rb
@@ -59,7 +59,7 @@ module SelectsHelper
def users_select_data_attributes(opts)
{
- placeholder: opts[:placeholder] || 'Search for members to update or invite',
+ placeholder: opts[:placeholder] || 'Search for a user',
null_user: opts[:null_user] || false,
any_user: opts[:any_user] || false,
email_user: opts[:email_user] || false,
diff --git a/app/views/projects/group_links/_index.html.haml b/app/views/projects/group_links/_index.html.haml
index 797b47f6c0b..99d0df2ac34 100644
--- a/app/views/projects/group_links/_index.html.haml
+++ b/app/views/projects/group_links/_index.html.haml
@@ -8,7 +8,7 @@
.col-lg-9
%h5.prepend-top-0
Set a group to share
- = form_tag namespace_project_group_links_path(@project.namespace, @project), class: 'js-requires-input', method: :post, namespace: 'GROUPS' do
+ = form_tag namespace_project_group_links_path(@project.namespace, @project), class: 'js-requires-input', method: :post do
.form-group
= label_tag :link_group_id, "Group", class: "label-light"
= groups_select_tag(:link_group_id, data: { skip_groups: @skip_groups }, required: true)
diff --git a/app/views/projects/project_members/_new_project_member.html.haml b/app/views/projects/project_members/_new_project_member.html.haml
index 784115f1ab0..18d30eeb86b 100644
--- a/app/views/projects/project_members/_new_project_member.html.haml
+++ b/app/views/projects/project_members/_new_project_member.html.haml
@@ -1,7 +1,7 @@
= form_for @project_member, as: :project_member, url: namespace_project_project_members_path(@project.namespace, @project), html: { class: 'users-project-form' } do |f|
.row
.col-md-5.col-lg-5
- = users_select_tag(:user_ids, multiple: true, class: "input-clamp", scope: :all, email_user: true)
+ = users_select_tag(:user_ids, multiple: true, class: "input-clamp", scope: :all, email_user: true, placeholder: "Search for members to update or invite")
.help-block.append-bottom-10
Search for members by name, username, or email, or invite new ones using their email address.