diff options
author | Grzegorz Bizon <grzegorz@gitlab.com> | 2018-09-14 08:51:16 +0000 |
---|---|---|
committer | Grzegorz Bizon <grzegorz@gitlab.com> | 2018-09-14 08:51:16 +0000 |
commit | f076358491400008dfaa1c4b4c545acc66236706 (patch) | |
tree | adc2860329dacc1a1aea18f1bf59123370876288 /app | |
parent | bb708a06e0fb02997b12ef31089485f9b7e54909 (diff) | |
parent | e580c2261d12b4542eafba6b5db3b3656d57ed63 (diff) | |
download | gitlab-ce-f076358491400008dfaa1c4b4c545acc66236706.tar.gz |
Merge branch 'ccr/50483_add_filter_for_group_milestones' into 'master'
Filter group milestones based on user membership.
See merge request gitlab-org/gitlab-ce!21660
Diffstat (limited to 'app')
-rw-r--r-- | app/controllers/dashboard/milestones_controller.rb | 2 | ||||
-rw-r--r-- | app/models/dashboard_group_milestone.rb | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/app/controllers/dashboard/milestones_controller.rb b/app/controllers/dashboard/milestones_controller.rb index 0469e7e1e1f..78f7f6d4e23 100644 --- a/app/controllers/dashboard/milestones_controller.rb +++ b/app/controllers/dashboard/milestones_controller.rb @@ -22,7 +22,7 @@ class Dashboard::MilestonesController < Dashboard::ApplicationController private def group_milestones - groups = GroupsFinder.new(current_user, all_available: true).execute + groups = GroupsFinder.new(current_user, all_available: false).execute DashboardGroupMilestone.build_collection(groups) end diff --git a/app/models/dashboard_group_milestone.rb b/app/models/dashboard_group_milestone.rb index 4e39f60b0d2..067e14dda1c 100644 --- a/app/models/dashboard_group_milestone.rb +++ b/app/models/dashboard_group_milestone.rb @@ -13,7 +13,7 @@ class DashboardGroupMilestone < GlobalMilestone end def self.build_collection(groups) - MilestonesFinder.new(group_ids: groups.pluck(:id)).execute.map { |m| new(m) } # rubocop: disable CodeReuse/Finder + MilestonesFinder.new(group_ids: groups.select(:id)).execute.map { |m| new(m) } # rubocop: disable CodeReuse/Finder end override :group_milestone? |