diff options
author | Douwe Maan <douwe@gitlab.com> | 2018-03-01 17:40:24 +0000 |
---|---|---|
committer | Douwe Maan <douwe@gitlab.com> | 2018-03-01 17:40:24 +0000 |
commit | 008120f8db90dcf65fdd00343a4d8a22695abed1 (patch) | |
tree | 274e896be3f9b4b33fd922c4860668becbf74a93 /app | |
parent | ccb080d94aa765d8391f262e25c5ead0764dc2ff (diff) | |
parent | 522f4b2c6a0a1fe1e93d7bc2f9fe5290fccba4f9 (diff) | |
download | gitlab-ce-008120f8db90dcf65fdd00343a4d8a22695abed1.tar.gz |
Merge branch '41777-include-cycle-time-in-usage-ping' into 'master'
Resolve "Include cycle time in usage ping"
Closes #41777
See merge request gitlab-org/gitlab-ce!16793
Diffstat (limited to 'app')
-rw-r--r-- | app/models/cycle_analytics.rb | 6 | ||||
-rw-r--r-- | app/serializers/analytics_stage_entity.rb | 3 |
2 files changed, 8 insertions, 1 deletions
diff --git a/app/models/cycle_analytics.rb b/app/models/cycle_analytics.rb index d2e626c22e8..b34d1382d43 100644 --- a/app/models/cycle_analytics.rb +++ b/app/models/cycle_analytics.rb @@ -6,6 +6,12 @@ class CycleAnalytics @options = options end + def all_medians_per_stage + STAGES.each_with_object({}) do |stage_name, medians_per_stage| + medians_per_stage[stage_name] = self[stage_name].median + end + end + def summary @summary ||= ::Gitlab::CycleAnalytics::StageSummary.new(@project, from: @options[:from], diff --git a/app/serializers/analytics_stage_entity.rb b/app/serializers/analytics_stage_entity.rb index 564612202b5..3e355a13e06 100644 --- a/app/serializers/analytics_stage_entity.rb +++ b/app/serializers/analytics_stage_entity.rb @@ -7,6 +7,7 @@ class AnalyticsStageEntity < Grape::Entity expose :description expose :median, as: :value do |stage| - stage.median && !stage.median.zero? ? distance_of_time_in_words(stage.median) : nil + # median returns a BatchLoader instance which we first have to unwrap by using to_i + !stage.median.to_i.zero? ? distance_of_time_in_words(stage.median) : nil end end |