summaryrefslogtreecommitdiff
path: root/app
diff options
context:
space:
mode:
authorLin Jen-Shin <godfat@godfat.org>2019-07-25 16:37:05 +0000
committerLin Jen-Shin <godfat@godfat.org>2019-07-25 16:37:05 +0000
commit767c5f63886536eefc4daf081ecba5b45fe8cc3c (patch)
treef6874ad0f833920ca1eef6639e3f0e892fa76c21 /app
parentaa9db9c869ecbc570bd03f02dd3febf32f99d560 (diff)
parent7cf4bf848f9d3018af2c87d7c88b26b7610db995 (diff)
downloadgitlab-ce-767c5f63886536eefc4daf081ecba5b45fe8cc3c.tar.gz
Merge branch 'label-descr-push-opts' into 'master'
Support title and desc on merge w/ push option See merge request gitlab-org/gitlab-ce!31068
Diffstat (limited to 'app')
-rw-r--r--app/services/merge_requests/push_options_handler_service.rb17
1 files changed, 8 insertions, 9 deletions
diff --git a/app/services/merge_requests/push_options_handler_service.rb b/app/services/merge_requests/push_options_handler_service.rb
index 6d70b5106c7..b210004e6e1 100644
--- a/app/services/merge_requests/push_options_handler_service.rb
+++ b/app/services/merge_requests/push_options_handler_service.rb
@@ -118,7 +118,14 @@ module MergeRequests
end
def base_params
- params = {}
+ params = {
+ title: push_options[:title],
+ description: push_options[:description],
+ target_branch: push_options[:target],
+ force_remove_source_branch: push_options[:remove_source_branch]
+ }
+
+ params.compact!
if push_options.key?(:merge_when_pipeline_succeeds)
params.merge!(
@@ -127,14 +134,6 @@ module MergeRequests
)
end
- if push_options.key?(:remove_source_branch)
- params[:force_remove_source_branch] = push_options[:remove_source_branch]
- end
-
- if push_options.key?(:target)
- params[:target_branch] = push_options[:target]
- end
-
params
end