summaryrefslogtreecommitdiff
path: root/app
diff options
context:
space:
mode:
authorMałgorzata Ksionek <mksionek@gitlab.com>2019-07-16 11:38:19 +0200
committerMałgorzata Ksionek <mksionek@gitlab.com>2019-07-16 12:33:42 +0200
commit1dde18f39424f6eaebe1777d0bfa35c5805178cd (patch)
treed056bf8a1b54261d39c44c1f489acd6342a80b9d /app
parent72cddf5a1f7e851864661ad97a611b1ef8d5563a (diff)
downloadgitlab-ce-1dde18f39424f6eaebe1777d0bfa35c5805178cd.tar.gz
Add code review remarks
Make specs more readable
Diffstat (limited to 'app')
-rw-r--r--app/models/cycle_analytics/group_level.rb2
-rw-r--r--app/models/cycle_analytics/level_base.rb (renamed from app/models/cycle_analytics/base_methods.rb)2
-rw-r--r--app/models/cycle_analytics/project_level.rb2
3 files changed, 3 insertions, 3 deletions
diff --git a/app/models/cycle_analytics/group_level.rb b/app/models/cycle_analytics/group_level.rb
index 58bd2eb0d9a..35efd8b8809 100644
--- a/app/models/cycle_analytics/group_level.rb
+++ b/app/models/cycle_analytics/group_level.rb
@@ -2,7 +2,7 @@
module CycleAnalytics
class GroupLevel
- include BaseMethods
+ include LevelBase
attr_reader :options
def initialize(options:)
diff --git a/app/models/cycle_analytics/base_methods.rb b/app/models/cycle_analytics/level_base.rb
index 1c2a0854769..543349ebf8f 100644
--- a/app/models/cycle_analytics/base_methods.rb
+++ b/app/models/cycle_analytics/level_base.rb
@@ -1,7 +1,7 @@
# frozen_string_literal: true
module CycleAnalytics
- module BaseMethods
+ module LevelBase
STAGES = %i[issue plan code test review staging production].freeze
def all_medians_by_stage
diff --git a/app/models/cycle_analytics/project_level.rb b/app/models/cycle_analytics/project_level.rb
index abe1be11eae..4aa426c58a1 100644
--- a/app/models/cycle_analytics/project_level.rb
+++ b/app/models/cycle_analytics/project_level.rb
@@ -2,7 +2,7 @@
module CycleAnalytics
class ProjectLevel
- include BaseMethods
+ include LevelBase
attr_reader :project, :options
def initialize(project, options:)