diff options
| author | Timothy Andrew <mail@timothyandrew.net> | 2017-05-03 09:29:49 +0000 |
|---|---|---|
| committer | Timothy Andrew <mail@timothyandrew.net> | 2017-05-04 04:21:12 +0000 |
| commit | b44eaf8e0772d4ab076bd0df10b13085483e5e66 (patch) | |
| tree | 11cd8ca1fcbe1810de0ee1874302bcf4520af90d /changelogs/unreleased/30973-network-graph-sorted-by-date-and-topo.yml | |
| parent | f930c66e2cd55b6760042e775d91df538a4dabf7 (diff) | |
| download | gitlab-ce-b44eaf8e0772d4ab076bd0df10b13085483e5e66.tar.gz | |
Sort the network graph both by commit date and topographically.30973-network-graph-sorted-by-date-and-topo
- Previously, we sorted commits by date, which seemed to work okay.
- The one edge case where this failed was when multiple commits have the same
commit date (for example: when a range of commits are cherry picked with a
single command, they all have the same commit date [and different author
dates]).
- Commits with the same commit date would be sorted arbitrarily, and usually
break the network graph.
- This commit solves the problem by both sorting by date, and by sorting
topographically (parents aren't displayed until all their children are
displayed)
- Include review comments from @adamniedzielski
A more detailed explanation is present here:
https://gitlab.com/gitlab-org/gitlab-ce/issues/30973#note_28706230
Diffstat (limited to 'changelogs/unreleased/30973-network-graph-sorted-by-date-and-topo.yml')
| -rw-r--r-- | changelogs/unreleased/30973-network-graph-sorted-by-date-and-topo.yml | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/changelogs/unreleased/30973-network-graph-sorted-by-date-and-topo.yml b/changelogs/unreleased/30973-network-graph-sorted-by-date-and-topo.yml new file mode 100644 index 00000000000..42426c1865e --- /dev/null +++ b/changelogs/unreleased/30973-network-graph-sorted-by-date-and-topo.yml @@ -0,0 +1,4 @@ +--- +title: Sort the network graph both by commit date and topographically +merge_request: 11057 +author: |