diff options
| author | Gabriel Mazetto <brodock@gmail.com> | 2019-01-17 02:53:50 +0100 |
|---|---|---|
| committer | Gabriel Mazetto <brodock@gmail.com> | 2019-01-21 17:15:30 +0100 |
| commit | 7a7948e64b2d5bd9f00f9f58862b0a0599e78c83 (patch) | |
| tree | 2debbdad1aca909c8f71152972e02b110551fd27 /changelogs/unreleased/56636-hashed-storage-afterrenameservice.yml | |
| parent | d56b76a52dbb978982c3dedba333523e908b37db (diff) | |
| download | gitlab-ce-7a7948e64b2d5bd9f00f9f58862b0a0599e78c83.tar.gz | |
Fixed legacy storage renaming code
During a previous refactor on project model, code related to the
hashed storage was extracted into AfterRenameService, see
4b9c17f196bab6075563f62d01f9db65c1a0515c.
The "path_before" was changed from using `previous_changes['path']` to
`path_was`. They are not equivalent. `path_was` exists reliably only
*before* persisting to the database. After database persistence is
confirmed, the value is moved to `previous_changes[:attribute_name]`.
Because the repository/attachments rename or storage upgrade happens
after it was persisted to the database, we were in fact not informing
the right parameters (and therefore not doing what it was supposed to).
Diffstat (limited to 'changelogs/unreleased/56636-hashed-storage-afterrenameservice.yml')
0 files changed, 0 insertions, 0 deletions