diff options
| author | Bob Van Landuyt <bob@vanlanduyt.co> | 2017-11-17 15:55:43 +0100 |
|---|---|---|
| committer | Bob Van Landuyt <bob@vanlanduyt.co> | 2017-11-17 16:20:47 +0100 |
| commit | 5a335c4d955bbb74a50ca30ac45d30f6ef66774d (patch) | |
| tree | 490aae02c5cb2a2d1774c8b7094e9c7bc4c2c3a8 /changelogs/unreleased | |
| parent | 4aa18590b3af27c9cb3cd3c2fc8c0a70e9a8758e (diff) | |
| download | gitlab-ce-5a335c4d955bbb74a50ca30ac45d30f6ef66774d.tar.gz | |
Remove the selects when counting the last page
The last page of the first collection is only loaded into memory when
it is being viewed. If it isn't loaded into memory, the `#size` call
triggers a count query.
This `#count` would generate an invalid query if our custom preloaded
counts are included by adding a separate `as count_column` alias on
top of the count aliases. Removing the selects in this case will make
sure a valid `COUNT(*)` is generated.
Diffstat (limited to 'changelogs/unreleased')
| -rw-r--r-- | changelogs/unreleased/bvl-fix-count-with-selects.yml | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/changelogs/unreleased/bvl-fix-count-with-selects.yml b/changelogs/unreleased/bvl-fix-count-with-selects.yml new file mode 100644 index 00000000000..46a882de524 --- /dev/null +++ b/changelogs/unreleased/bvl-fix-count-with-selects.yml @@ -0,0 +1,6 @@ +--- +title: Fix crash when navigating to second page of the group dashbaord when there + are projects and groups on the first page +merge_request: 15456 +author: +type: fixed |