diff options
author | Achilleas Pipinellis <axilleas@axilleas.me> | 2016-11-22 20:26:58 +0000 |
---|---|---|
committer | Achilleas Pipinellis <axilleas@axilleas.me> | 2016-11-22 20:26:58 +0000 |
commit | 448c19aab1689ef43658a1f0fa0315e206ae895f (patch) | |
tree | f51ab54841a85bb32cdfd93c1b70c9c771f0549e /changelogs/unreleased | |
parent | 65e5d5cd8af3c6a94a46c1174832c1fe02e5b0a3 (diff) | |
parent | f2ccb1d309148770177031b71089efe5deb213ca (diff) | |
download | gitlab-ce-448c19aab1689ef43658a1f0fa0315e206ae895f.tar.gz |
Merge branch 'patch-1' into 'master'
Update github.md
Hi, I ran into a few pitfalls while I enabled OmniAuth to be able to migrate repos from github to my omnibus-gitlab instance today, so here are my findings:
These docs state thate the default authorization callback URL is `'${YOUR_DOMAIN}/import/github/callback'`, but the screenshot only shows `'${YOUR_DOMAIN}'`, which works, so I removed the ambiguity.
When editing `gitlab_rails['omniauth_providers']` for github.com, you have to omit the `"url" => "https://github.com/",` part, otherwise it won't work (OmniAuth will stay deactivated). This is backed by the configuration details of the "from-source-installation" which also omits the url in the `yml` file.
After changing the `gitlab.rb` file, `sudo gitlab-ctl reconfigure` needs to be run, which is missing in the docs.
Following the updated version of this documentation I was able to enable OmniAuth.
If anything I edited is wrong, please correct me, as I don't know how the "from-source-installations" would react to my changes.
Best regards,
Florian
See merge request !4072
Diffstat (limited to 'changelogs/unreleased')
0 files changed, 0 insertions, 0 deletions