diff options
| author | Stan Hu <stanhu@gmail.com> | 2019-02-01 13:18:41 -0800 |
|---|---|---|
| committer | Stan Hu <stanhu@gmail.com> | 2019-02-01 22:32:53 -0800 |
| commit | 1f1882368710a0c093ec9c2f036e87d28d8c5b3b (patch) | |
| tree | 14d1c018ae87d437525075f8bef271d2337d0168 /changelogs | |
| parent | dd26a9addc5dd654e3c8eecb58216f1f4449cfc1 (diff) | |
| download | gitlab-ce-1f1882368710a0c093ec9c2f036e87d28d8c5b3b.tar.gz | |
Downcase aliased OAuth2 callback providers
Users may specify an OAuth2 callback with a custom name, such as
AWSCognito, but Rails will reject this with the following message:
```
'import/AWSCognito' is not a supported controller name. This can
lead to potential routing problems. See
http://guides.rubyonrails.org/routing.html#specifying-a-controller-to-use
```
To avoid these errors, we can just downcase all the provider names.
Note that this will make it impossible to specify a duplicate name with
different cases.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/57156
Diffstat (limited to 'changelogs')
| -rw-r--r-- | changelogs/unreleased/sh-fix-oauth2-callback-caps.yml | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/changelogs/unreleased/sh-fix-oauth2-callback-caps.yml b/changelogs/unreleased/sh-fix-oauth2-callback-caps.yml new file mode 100644 index 00000000000..8d17900cb79 --- /dev/null +++ b/changelogs/unreleased/sh-fix-oauth2-callback-caps.yml @@ -0,0 +1,5 @@ +--- +title: Downcase aliased OAuth2 callback providers +merge_request: 24877 +author: +type: fixed |