diff options
| author | Stan Hu <stanhu@gmail.com> | 2017-06-01 13:15:46 -0700 |
|---|---|---|
| committer | Stan Hu <stanhu@gmail.com> | 2017-06-04 21:51:59 -0700 |
| commit | 37dd073782520f70d021e8ca9960e0a1c9696129 (patch) | |
| tree | 6f22e45c5cd7b9d836502a3f4bada0e0e5b325fe /changelogs | |
| parent | 39340e428e3546d3749498ce10b19ae6cda0e646 (diff) | |
| download | gitlab-ce-37dd073782520f70d021e8ca9960e0a1c9696129.tar.gz | |
Fix LFS timeouts when trying to save large filessh-fix-lfs-from-moving-across-filesystems
The following was happening:
1. Workhorse stores an LFS file in /var/opt/gitlab/gitlab-rails/shared/lfs-objects
2. CarrierWave then renames the file to a temporary directory (e.g. /opt/gitlab/embedded/service/gitlab-rails/tmp)
3. CarrierWave then renames the file to its final location (e.g. /var/opt/gitlab/gitlab-rails/shared/lfs-objects)
When the LFS upload path was on a different filesystem than the Rails
installation, step 2 could take a longer than 10 seconds, at which point Workhorse
would time out with "badgateway: failed after 10s: context canceled".
This change makes the work path in the same root as the LFS storage path, preventing moves
across filesystems.
Closes #33218
Diffstat (limited to 'changelogs')
| -rw-r--r-- | changelogs/unreleased/sh-fix-lfs-from-moving-across-filesystems.yml | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/changelogs/unreleased/sh-fix-lfs-from-moving-across-filesystems.yml b/changelogs/unreleased/sh-fix-lfs-from-moving-across-filesystems.yml new file mode 100644 index 00000000000..161bce45601 --- /dev/null +++ b/changelogs/unreleased/sh-fix-lfs-from-moving-across-filesystems.yml @@ -0,0 +1,4 @@ +--- +title: Fix LFS timeouts when trying to save large files +merge_request: +author: |