diff options
| author | Sean McGivern <sean@gitlab.com> | 2017-07-11 10:53:58 +0100 |
|---|---|---|
| committer | Sean McGivern <sean@gitlab.com> | 2017-07-11 13:02:55 +0100 |
| commit | 222a6b4680b19f578b42b32d908a1d3cb8e343f7 (patch) | |
| tree | 9c0e8b251efde7e67a3a500a4b2cecae1cd496f0 /changelogs | |
| parent | c17b1d5f5651b6f73b8c999bb6a5376e31a7d30d (diff) | |
| download | gitlab-ce-222a6b4680b19f578b42b32d908a1d3cb8e343f7.tar.gz | |
Don't reload ActiveRecord objects when building note URLs
When we build a note URL, and we have the note loaded already, there are two
cases:
1. The `noteable` is already loaded. In that case, this is faster as it doesn't
build a new AR object from the query.
2. The `noteable` is not already loaded. In that case, this change is no worse
than the previous code.
Diffstat (limited to 'changelogs')
| -rw-r--r-- | changelogs/unreleased/fix-n-plus-one-in-url-builder.yml | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/changelogs/unreleased/fix-n-plus-one-in-url-builder.yml b/changelogs/unreleased/fix-n-plus-one-in-url-builder.yml new file mode 100644 index 00000000000..5781316cfd9 --- /dev/null +++ b/changelogs/unreleased/fix-n-plus-one-in-url-builder.yml @@ -0,0 +1,4 @@ +--- +title: Improve issue rendering performance with lots of notes from other users +merge_request: +author: |