diff options
| author | Bob Van Landuyt <bob@vanlanduyt.co> | 2018-05-15 12:25:51 +0200 |
|---|---|---|
| committer | Bob Van Landuyt <bob@vanlanduyt.co> | 2018-06-11 17:35:13 +0200 |
| commit | 698515313fe38fb3f85fdeec1efa15e2c8b54cfd (patch) | |
| tree | f48e87c94ddbd458319168056596e993f38e76b2 /changelogs | |
| parent | 75797ac3d2b534a1deda48c8450027055a7c721b (diff) | |
| download | gitlab-ce-698515313fe38fb3f85fdeec1efa15e2c8b54cfd.tar.gz | |
Fixes rejected pushes from maintainersbvl-fix-maintainer-push-rejected
Before the push git would make a call to
`/:namespace/:project/git-receive-pack`. This would perform an access
check without a ref. So the `Project#branch_allows_maintainer_push?`
would return false.
This adjusts `Project#branch_allows_maintainer_push?` to return true
when passing no branch name if there are merge requests open that
would allow the user to push.
The actual check then happens when a call to
`/api/v4/internal/allowed` is made from a git hook.
Diffstat (limited to 'changelogs')
| -rw-r--r-- | changelogs/unreleased/bvl-fix-maintainer-push-rejected.yml | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/changelogs/unreleased/bvl-fix-maintainer-push-rejected.yml b/changelogs/unreleased/bvl-fix-maintainer-push-rejected.yml new file mode 100644 index 00000000000..54154ad2449 --- /dev/null +++ b/changelogs/unreleased/bvl-fix-maintainer-push-rejected.yml @@ -0,0 +1,6 @@ +--- +title: Fix bug where maintainer would not be allowed to push to forks with merge requests + that have `Allow maintainer edits` enabled. +merge_request: 18968 +author: +type: fixed |