diff options
| author | Filipa Lacerda <filipa@gitlab.com> | 2018-07-09 18:13:41 +0100 |
|---|---|---|
| committer | Filipa Lacerda <filipa@gitlab.com> | 2018-07-10 12:03:00 +0100 |
| commit | ac71675d3096ac9317ea230a408d69029bdadc73 (patch) | |
| tree | 25ac9376545ed94915f38cd05c4ec5d0b6af2e42 /changelogs | |
| parent | cb6bc902ed1f89e7f94caa86b75e756b9163af51 (diff) | |
| download | gitlab-ce-ac71675d3096ac9317ea230a408d69029bdadc73.tar.gz | |
Fixes toggle discussion button not expanding collapsed discussions
Discussions were being toggled by jquery DOM querying them and toggling
visibility but in vue, only the open discussions will be in the DOM
Fix includes:
- Adds a getter to the store to get the expanded discussions
- Adds an action to collapse a discussion
- When the user clicks the button, all data needed is now accessible
through a getter and we can dispatch an action to toggle the discussion
within the state, instead of showing/hiding with jQuery
- Removes hardcoded properties
Resolves #48237
Diffstat (limited to 'changelogs')
| -rw-r--r-- | changelogs/unreleased/48237-toggle-file-comments.yml | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/changelogs/unreleased/48237-toggle-file-comments.yml b/changelogs/unreleased/48237-toggle-file-comments.yml new file mode 100644 index 00000000000..9c9b8e95691 --- /dev/null +++ b/changelogs/unreleased/48237-toggle-file-comments.yml @@ -0,0 +1,5 @@ +--- +title: Fixes toggle discussion button not expanding collapsed discussions +merge_request: +author: +type: fixed |