diff options
| author | Yorick Peterse <yorickpeterse@gmail.com> | 2017-08-18 14:26:23 +0200 |
|---|---|---|
| committer | Yorick Peterse <yorickpeterse@gmail.com> | 2017-08-29 13:02:44 +0200 |
| commit | 5eab624d3ce7500b3cc19230b5ce86125b88015b (patch) | |
| tree | cbfd2c470c9009fce1449a837d60058bed026aa0 /changelogs | |
| parent | 9e7e0496ff639d1eec65dcbf1b51edb2262456e2 (diff) | |
| download | gitlab-ce-5eab624d3ce7500b3cc19230b5ce86125b88015b.tar.gz | |
Improve migrations using triggerscheck-trigger-permissions-mysql
This adds a bunch of checks to migrations that may create or drop
triggers. Dropping triggers/functions is done using "IF EXISTS" so we
don't throw an error if the object in question has already been dropped.
We now also raise a custom error (message) when the user does not have
TRIGGER privileges. This should prevent the schema from entering an
inconsistent state while also providing the user with enough information
on how to solve the problem.
The recommendation of using SUPERUSER permissions is a bit extreme but
we require this anyway (Omnibus also configures users with this
permission).
Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/36633
Diffstat (limited to 'changelogs')
| -rw-r--r-- | changelogs/unreleased/check-trigger-permissions.yml | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/changelogs/unreleased/check-trigger-permissions.yml b/changelogs/unreleased/check-trigger-permissions.yml new file mode 100644 index 00000000000..e0809cea9bf --- /dev/null +++ b/changelogs/unreleased/check-trigger-permissions.yml @@ -0,0 +1,5 @@ +--- +title: Improve migrations using triggers +merge_request: +author: +type: fixed |