diff options
| author | Stan Hu <stanhu@gmail.com> | 2019-07-19 10:01:09 -0700 |
|---|---|---|
| committer | Stan Hu <stanhu@gmail.com> | 2019-07-19 10:03:41 -0700 |
| commit | ec5ceae623fceff0a959c7d297970d37285532dc (patch) | |
| tree | 1cf6083ee561298c1c1f5c652ecf315f95238d9a /changelogs | |
| parent | 2e56b134687ccc8043f14eef4c5d0bfa9e1fd370 (diff) | |
| download | gitlab-ce-ec5ceae623fceff0a959c7d297970d37285532dc.tar.gz | |
Fix Gitaly auto-detection caching
If `GitalyClient#can_use_disk?` returned `false`, it was never cached
properly and led to excessive number of Gitaly calls. Instead of using
`cached_value.present?`, we need to check `cached_value.nil?`.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/64802
Diffstat (limited to 'changelogs')
| -rw-r--r-- | changelogs/unreleased/sh-fix-gitaly-server-info-cache.yml | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/changelogs/unreleased/sh-fix-gitaly-server-info-cache.yml b/changelogs/unreleased/sh-fix-gitaly-server-info-cache.yml new file mode 100644 index 00000000000..ef8f6e25856 --- /dev/null +++ b/changelogs/unreleased/sh-fix-gitaly-server-info-cache.yml @@ -0,0 +1,5 @@ +--- +title: Fix Gitaly auto-detection caching +merge_request: 30954 +author: +type: performance |