diff options
| author | Sean McGivern <sean@gitlab.com> | 2019-03-22 15:51:14 +0000 |
|---|---|---|
| committer | Sean McGivern <sean@gitlab.com> | 2019-03-25 12:12:44 +0000 |
| commit | c5f9b2be826c05e5f06d424f5c110976ad0b68c4 (patch) | |
| tree | 6c7d4e5f2beb1b4d942bfc409a8b1e44563b35ad /changelogs | |
| parent | 05c6de9867f25aa5e6373d7b32d925572bdb4686 (diff) | |
| download | gitlab-ce-c5f9b2be826c05e5f06d424f5c110976ad0b68c4.tar.gz | |
Remove N+1 queries from users autocomplete
Both of these were related to groups:
1. We need to preload routes (using the `with_route` scope) if we're
going to get the group's path.
2. We were counting each group's members separately.
They're in the same commit because the spec for N+1 detection wouldn't
pass with only one of these fixes.
Diffstat (limited to 'changelogs')
| -rw-r--r-- | changelogs/unreleased/fix-routes-n-plus-one-in-user-autocomplete.yml | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/changelogs/unreleased/fix-routes-n-plus-one-in-user-autocomplete.yml b/changelogs/unreleased/fix-routes-n-plus-one-in-user-autocomplete.yml new file mode 100644 index 00000000000..ae097e859d9 --- /dev/null +++ b/changelogs/unreleased/fix-routes-n-plus-one-in-user-autocomplete.yml @@ -0,0 +1,5 @@ +--- +title: Fix some N+1s in loading routes and counting members for groups in @-autocomplete +merge_request: 26491 +author: +type: performance |