diff options
| author | Sean McGivern <sean@gitlab.com> | 2017-07-28 13:59:57 +0100 |
|---|---|---|
| committer | Sean McGivern <sean@gitlab.com> | 2017-07-28 13:59:57 +0100 |
| commit | fdfb4bbe5c659e02734258615b57b5f012afb2b4 (patch) | |
| tree | fc21d52ad74c37bf59608e2271b398ef17d2cf8e /changelogs | |
| parent | 4ccecb7db4879b0eae8211578b533911ee8920df (diff) | |
| download | gitlab-ce-fdfb4bbe5c659e02734258615b57b5f012afb2b4.tar.gz | |
Fix diff commenting results just after changing view35695-comment-appears-in-a-wrong-place-after-changing-diff-view-to-inline
When you change the diff view (inline / side-by-side), we set a cookie based on
that new view. When you add a comment, we choose the style to use in the
response based on that cookie.
However, when you have just changed diff style, the request cookie will contain
the old value, so we should use the view param instead.
Diffstat (limited to 'changelogs')
| -rw-r--r-- | changelogs/unreleased/35695-comment-appears-in-a-wrong-place-after-changing-diff-view-to-inline.yml | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/changelogs/unreleased/35695-comment-appears-in-a-wrong-place-after-changing-diff-view-to-inline.yml b/changelogs/unreleased/35695-comment-appears-in-a-wrong-place-after-changing-diff-view-to-inline.yml new file mode 100644 index 00000000000..1c9ad20bc95 --- /dev/null +++ b/changelogs/unreleased/35695-comment-appears-in-a-wrong-place-after-changing-diff-view-to-inline.yml @@ -0,0 +1,4 @@ +--- +title: Fix display of new diff comments after changing b between diff views +merge_request: +author: |