diff options
| author | Adam Niedzielski <adamsunday@gmail.com> | 2016-11-28 15:04:51 +0100 |
|---|---|---|
| committer | Adam Niedzielski <adamsunday@gmail.com> | 2016-11-28 15:04:51 +0100 |
| commit | cf58271e11f6704523be5211ecfb2d02ae1091fe (patch) | |
| tree | 330a22a76839735305dd18701655bf21f60478a7 /changelogs | |
| parent | 9e6cdc64741583ed0db74485892c1970ff960eab (diff) | |
| download | gitlab-ce-cf58271e11f6704523be5211ecfb2d02ae1091fe.tar.gz | |
Pass tag SHA to post-receive hook when tag is created via UI24813-project-members-with-developer-access-can-no-longer-create-tags
We only know the tag SHA after we create the tag.
This means that we pass a different value to the hooks that happen before
creating the tag, and a different value to the hooks that happen after
creating the tag.
This is not an ideal situation, but it is a trade-off we decided to
make. For discussion of the alternatives please refer to
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7700#note_18982873
"pre-receive" and "update" hooks always get the SHA of the commit
that the tag points to. "post-receive" gets the tag SHA if it is
an annotated tag or the commit SHA if it is an lightweight tag.
Currently we always create annotated tags if UI is used.
Diffstat (limited to 'changelogs')
| -rw-r--r-- | changelogs/unreleased/24813-project-members-with-developer-access-can-no-longer-create-tags.yml | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/changelogs/unreleased/24813-project-members-with-developer-access-can-no-longer-create-tags.yml b/changelogs/unreleased/24813-project-members-with-developer-access-can-no-longer-create-tags.yml new file mode 100644 index 00000000000..9254db40742 --- /dev/null +++ b/changelogs/unreleased/24813-project-members-with-developer-access-can-no-longer-create-tags.yml @@ -0,0 +1,4 @@ +--- +title: Pass tag SHA to post-receive hook when tag is created via UI +merge_request: 7700 +author: |